Move analyzer package references from Directory.Build.props to src csproj#84
Merged
Chris-Wolfgang merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
…proj Analyzer packages (Roslynator, AsyncFixer, Microsoft.VisualStudio.Threading, BannedApiAnalyzers, Meziantou, SonarAnalyzer) and the BannedSymbols.txt AdditionalFiles entry now live in the source library project's csproj instead of being inherited by every project in the repo. Behavior change: tests, benchmarks, and examples no longer get analyzer warnings/errors. Only the shipped library code (Wolfgang.TryPattern) is subject to analyzer enforcement. Directory.Build.props retains the property settings (LangVersion, EnableNETAnalyzers, AnalysisLevel, EnforceCodeStyleInBuild, TreatWarningsAsErrors) which still apply repo-wide. Verified: dotnet build succeeds with 0 warnings, all 96 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Chris-Wolfgang
added a commit
that referenced
this pull request
Apr 25, 2026
Resolves merge conflict with main (PR #84 moved Meziantou.Analyzer from Directory.Build.props to src/Wolfgang.TryPattern.csproj). Applies the Dependabot version bump in the new location. --- updated-dependencies: - dependency-name: Meziantou.Analyzer dependency-version: 3.0.54 dependency-type: direct:production update-type: version-update:semver-patch ... Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Chris-Wolfgang
added a commit
that referenced
this pull request
Apr 25, 2026
Resolves merge conflict with main (PR #84 moved Meziantou.Analyzer from Directory.Build.props to src/Wolfgang.TryPattern.csproj). Applies the Dependabot version bump in the new location. --- updated-dependencies: - dependency-name: Meziantou.Analyzer dependency-version: 3.0.54 dependency-type: direct:production update-type: version-update:semver-patch ... Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the analyzer NuGet package references and the `BannedSymbols.txt` `AdditionalFiles` entry out of `Directory.Build.props` and into `src/Wolfgang.TryPattern/Wolfgang.TryPattern.csproj`.
Packages moved:
Behavior change
Before: every project in the repo (src, tests, benchmarks, examples) inherited the analyzers.
After: only the shipped library project (`Wolfgang.TryPattern`) gets the analyzers. Tests, benchmarks, and examples build without analyzer warnings/errors.
`Directory.Build.props` still applies repo-wide for language/build settings:
Verification
🤖 Generated with Claude Code