Revert pr.yaml trigger to pull_request#74
Closed
Chris-Wolfgang wants to merge 2 commits into
Closed
Conversation
pull_request_target never fired after PR #72 merged — GitHub received the PR events but the workflow never ran, blocking all CI checks. Revert to pull_request trigger which worked reliably with v2. Also remove the ref/persist-credentials overrides that were only needed for pull_request_target (pull_request already checks out PR code). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s gated CI workflow to reliably run on PRs again by reverting the workflow trigger from pull_request_target back to pull_request, and removing checkout overrides that were only needed for pull_request_target.
Changes:
- Revert CI trigger from
pull_request_targettopull_requestfor PR validation. - Remove
ref: refs/pull/.../headandpersist-credentials:overrides fromactions/checkoutsteps. - Update the workflow’s security note to reflect the new trigger model (while keeping “trusted config fetch” behavior).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_targettrigger from PR Upgrade pr.yaml to v3 (Gated) #72 never fired — GitHub received PR events but the workflow never ran, blocking all CI checks on open PRspull_requesttrigger which worked reliablyref:/persist-credentials:checkout overrides (only needed forpull_request_target)Test plan
pull_requestworks)🤖 Generated with Claude Code