Sync pr.yaml with standard CI template#61
Merged
Conversation
Apply all template sync changes: add security header comment, switch gitleaks from action@v2 to CLI, add trusted config file fetch step to all stages and security scan, add 3.1.x to Linux/Windows SDK setup, add netcoreapp3.1 to test TFM extraction and Windows TFM filter, fix libssl to use apt instead of wget, fix DevSkim by removing continue-on-error and -E flag and adding exit 1, add CODECOV_MINIMUM env var, add coverage to Windows and macOS stages, update project filter to include netcoreapp|netstandard, replace while-read with mapfile, fix concurrency block formatting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Multi-line <TargetFrameworks> elements break the grep-based TFM detection in pr.yaml, causing CI to exclude all projects as "Framework-only". Single-line format is the project convention. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitleaks-action@v2to CLI invocation (v8.24.0) for pull_request compatibility.editorconfig,Directory.Build.props, etc. from main branch) after Checkout in all stages and security scan3.1.xto Linux and Windows .NET SDK setupnetcoreapp3.1to Linux test TFM extraction and Windows TFM filter regexfocal-securityrepo) instead of plainwgetdownloadcontinue-on-errorand-Eflag; addexit 1on critical/high findingsCODECOV_MINIMUM: 90env var at workflow levelnetcoreapp|netstandardpatternswhile-readwithmapfilefor test project discovery on Linux${CODECOV_MINIMUM:-90}in coverage threshold checksTest plan
🤖 Generated with Claude Code