Add application and package icons to project#50
Merged
Merged
Conversation
Added icon.ico as the application icon and icon.png as the NuGet package icon. Updated the project file to reference these icons appropriately. Also fixed a minor YAML issue in pr.yaml for the test-macos-core job.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds visual branding to the project by introducing application and package icons, and fixes a minor YAML syntax issue in the CI/CD workflow.
Changes:
- Added icon.ico as the application icon and icon.png as the NuGet package icon
- Updated Wolfgang.TryPattern.csproj to reference both icon files
- Fixed spacing in pr.yaml's test-macos-core job conditional expression
Reviewed changes
Copilot reviewed 1 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Wolfgang.TryPattern/icon.ico | New binary icon file added for application icon |
| asset/icon.png | New PNG icon file added for NuGet package icon |
| src/Wolfgang.TryPattern/Wolfgang.TryPattern.csproj | Added ApplicationIcon and PackageIcon properties, plus Content and None Include elements for icon files |
| .github/workflows/pr.yaml | Fixed spacing in conditional expression from github. repository to github.repository |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added icon.ico as the application icon and icon.png as the NuGet package icon. Updated the project file to reference these icons appropriately. Also fixed a minor YAML issue in pr.yaml for the test-macos-core job.
Description
Fixes/Complete # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist
Screenshots (if applicable)
Additional context