Skip to content

test: make the mid-flight cancellation test cover every line deterministically #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris-Wolfgang merged 1 commit into from
Sep 27, 2026
Merged

test: make the mid-flight cancellation test cover every line deterministically #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/Wolfgang.TryPattern.Tests.Unit/RunAsyncActionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,14 +247,17 @@ public async Task RunAsync_Action_CancellationToken_when_cancellation_is_request

void Action()
{
actionStarted.TrySetResult(true);

try
{
// Signal "started" only after a full pass of the loop body, so
// every line runs before the test can cancel. Signalling first
// let a fast runner cancel before the first delay, leaving that
// line uncovered on some runs (97.9% on macOS ARM64).
while (true)
{
cts.Token.ThrowIfCancellationRequested();
Task.Delay(10).Wait();
actionStarted.TrySetResult(true);
cts.Token.ThrowIfCancellationRequested();
}
}
catch (OperationCanceledException)
Expand Down
Loading