Skip to content

security(ci): pass step outcomes to the CodeQL summary through env, not template expansion #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris-Wolfgang merged 1 commit into from
Sep 26, 2026
Merged

security(ci): pass step outcomes to the CodeQL summary through env, not template expansion #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/codeql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,21 @@ jobs:
- name: Complete Security Scan
if: always()
shell: pwsh
# Step outcomes/outputs arrive through env rather than template expansion so nothing
# attacker-influenced is ever spliced into the script (zizmor template-injection).
env:
CHECK_CSHARP_OUTCOME: ${{ steps.check-csharp.outcome }}
HAS_CSHARP: ${{ steps.check-csharp.outputs.has-csharp }}
BUILD_OUTCOME: ${{ steps.build.outcome }}
CODEQL_OUTCOME: ${{ steps.perform-codeql-analysis.outcome }}
run: |
Write-Host "=== CodeQL Security Scan Complete ===" -ForegroundColor Cyan

# Check the outcome of previous steps
$checkCsharpOutcome = "${{ steps.check-csharp.outcome }}"
$hasCsharp = "${{ steps.check-csharp.outputs.has-csharp }}"
$buildOutcome = "${{ steps.build.outcome }}"
$codeqlOutcome = "${{ steps.perform-codeql-analysis.outcome }}"
$checkCsharpOutcome = "$env:CHECK_CSHARP_OUTCOME"
$hasCsharp = "$env:HAS_CSHARP"
$buildOutcome = "$env:BUILD_OUTCOME"
$codeqlOutcome = "$env:CODEQL_OUTCOME"

# Determine overall status
$hasFailure = $false
Expand Down
Loading