Repository navigation
test: unblock main after the template upgrade (test-assembly coverage gate, actionlint label) - #343
Merged
Merged
Conversation
…est assembly; actionlint label) The coverage gate now instruments the test assembly (template coverlet.runsettings) and three classes fell under 90%: - FuzzTests 0%: never run by the PR gate (--filter Category!=Fuzz), only by fuzz.yaml. [ExcludeFromCodeCoverage] with that reason; the same properties are measured through PropertyTests. - DocExampleCompilationTests / ReadmeExampleCompilationTests 87%: the failure-message builder (errors + indented snippet + hint) only runs when a snippet does not compile. Extracted into CompileFailureMessage.Format, shared by both, and covered by CompileFailureMessageTests with a deliberately broken snippet. The README test's null guard is one executed line now (CA1062 still satisfied). actions-audit.yaml: actionlint 1.7.7 -> 1.7.12 - 1.7.7 predates the windows-11-arm hosted-runner label used by cross-platform-differential.yaml (repo-template#576 carries the same bump). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
This pull request unblocks CI after the template upgrade by addressing coverage gates and updating actionlint for the hosted-runner label.
Changes:
- Excludes scheduled-only fuzz tests from PR coverage.
- Extracts and tests shared compilation-failure formatting.
- Upgrades actionlint to v1.7.12.
File summaries
| File | Description |
|---|---|
tests/Wolfgang.TryPattern.Tests.Unit/ReadmeExampleCompilationTests.cs |
Uses shared failure formatting and simplified null validation. |
tests/Wolfgang.TryPattern.Tests.Unit/FuzzTests.cs |
Excludes scheduled fuzz tests from coverage. |
tests/Wolfgang.TryPattern.Tests.Unit/DocExampleCompilationTests.cs |
Uses shared failure formatting. |
tests/Wolfgang.TryPattern.Tests.Unit/CompileFailureMessageTests.cs |
Tests compilation-failure formatting. |
tests/Wolfgang.TryPattern.Tests.Unit/CompileFailureMessage.cs |
Provides shared diagnostic formatting. |
.github/workflows/actions-audit.yaml |
Updates the actionlint version. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfails two checks since the template upgrade (#341) — first seen on the docs-only #342.Stage 1 coverage gate —
coverlet.runsettingsnow instruments the test assembly:FuzzTests0%: never executed by the PR gate (--filter "Category!=Fuzz"), only by the scheduledfuzz.yaml.[ExcludeFromCodeCoverage]with that reason; the same properties are measured throughPropertyTests.DocExampleCompilationTests/ReadmeExampleCompilationTests87%: the "snippet failed to compile" message builder (errors + indented snippet + hint) only runs on failure. Extracted into one sharedCompileFailureMessage.Formatand covered byCompileFailureMessageTestswith a deliberately broken snippet. The README test's null guard is a single executed line now (CA1062 still satisfied). Both new files carry the same#if NET8_0_OR_GREATERguard as their siblings (Roslyn is net8+ only in this project).actionlint — 1.7.7 predates the
windows-11-armhosted-runner label used bycross-platform-differential.yaml; bumped to 1.7.12 (Chris-Wolfgang/repo-template#576 carries the same bump). Workflow file → needs the bypass.Local gate: src 100%, test assembly 97.9%, no class under 90; Release build of the whole solution clean; 149/149 green. Test-only + workflow pin; no
src/change. Unblocks #342.🤖 Generated with Claude Code