Repository navigation
ci(pack): enable PackageValidation with baseline v0.4.1 (post-deploy baseline bump) - #319
Merged
Merged
Conversation
Post-deploy baseline bump for the v0.4.1 release. Turns on
Microsoft.DotNet.ApiCompat during `dotnet pack` (both local and
release.yaml) with v0.4.1 as the baseline, so accidental ABI breaks
(removed / renamed / type-changed public members) fail pack instead of
shipping.
Complements the existing `api-compat.yaml` PR workflow, which runs the
same validation dynamically against the latest-published NuGet version.
The static baseline here catches the same breaks earlier in the release
pipeline (at pack time, which `release.yaml` runs) and is the standard
fleet post-deploy baseline-bump step.
Verified locally: `dotnet pack -c Release` builds all 4 TFMs and creates
Wolfgang.TryPattern.0.4.1.{nupkg,snupkg} with package validation clean
(v0.4.1 vs v0.4.1 baseline is a no-op ABI diff; the mechanism is live
and will catch real breaks on the NEXT release's pack).
Next release will bump this value to whatever ships (e.g. 0.4.2, 0.5.0)
as part of that release's post-deploy baseline-bump PR.
Refs: #309, #317
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
PR benchmarks vs base (bc20979)Thresholds: time > +20% or allocations > +50% trigger a gate failure (label
|
1 of 3 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-deploy baseline bump for the v0.4.1 release just shipped. Turns on Microsoft.DotNet.ApiCompat during
dotnet pack(both local and `release.yaml`) with v0.4.1 as the baseline, so accidental ABI breaks (removed / renamed / type-changed public members) fail pack instead of shipping.Change
src/Wolfgang.TryPattern/Wolfgang.TryPattern.csproj:Plus a
<!-- ... -->comment above explaining the mechanism, the maintenance step (bump this baseline on every release), and the relationship toapi-compat.yaml(which already runs the same validation dynamically on PRs).Why this + api-compat.yaml both
api-compat.yamlruns ApiCompat against the latest-published NuGet version dynamically — great for catching breaks on PRs, before the release.PackageValidationBaselineVersionruns the same validation at pack time, so the check also runs insiderelease.yaml's `pack-and-validate` job (belt + suspenders — if a PR somehow slips through without triggeringapi-compat.yaml, this still catches it at release).Maintenance step this institutes
Every future release should bump
<PackageValidationBaselineVersion>to whatever version just shipped, as a post-deploy PR. That's the "post-deploy baseline bump" step in the per-repo release flow. This PR is the first application of it (there was no baseline in the csproj before).Test plan
dotnet pack -c Releaseon Wolfgang.TryPattern.csproj builds all 4 TFMs and packs Wolfgang.TryPattern.0.4.1.{nupkg,snupkg} with package validation clean. The v0.4.1-vs-v0.4.1 comparison is a no-op ABI diff by construction; the mechanism is live and will catch real breaks on the NEXT release's pack.pr.yamlStage 1/2/3 + SourceLink + AOT smoke + ApiCompat green.Refs: #309, #317
🤖 Generated with Claude Code