chore(benchmarks): curate benchmarks/.editorconfig, drop csproj NoWarn (#152)#212
Merged
Merged
Conversation
This was referenced Jun 27, 2026
#152) Move the benchmark-specific analyzer exemptions out of the csproj's <NoWarn> block into a curated benchmarks/.editorconfig, matching the tests/.editorconfig pattern: every suppression carries a per-rule reason, so a new analyzer hit is a deliberate carve-out (not a blanket exemption) and TreatWarningsAsErrors remains in force for benchmarks in Release. The root .editorconfig already covers benchmarks for the same rules; keeping a dedicated benchmarks/.editorconfig makes the source of truth local to the project (parallels tests/) and the csproj NoWarn is now redundant. Benchmarks still build clean in Release. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Chris-Wolfgang
force-pushed
the
chore/152-benchmarks-twae
branch
from
3a33abf to
1d2f218
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move benchmark-specific analyzer exemptions out of the csproj's
<NoWarn>block into a curatedbenchmarks/.editorconfig, mirroring thetests/.editorconfigpattern: every suppression carries a per-rule reason, so a new analyzer hit becomes a deliberate carve-out rather than a blanket exemption — andTreatWarningsAsErrorsstays in force for benchmarks in Release.The root
.editorconfigalready covers benchmarks for the same rules; keeping a dedicatedbenchmarks/.editorconfigmakes the source of truth local to the project (parallelstests/), and the csprojNoWarnblock becomes redundant.Verification
dotnet build -c Release benchmarks/...— 0 warnings, 0 errors.Stacking
Based on #211 — merge that first.
Closes #152.