Skip to content

Align conditional compilation directives with target frameworks#21

Closed
Copilot wants to merge 2 commits into
developfrom
copilot/sub-pr-20
Closed

Align conditional compilation directives with target frameworks#21
Copilot wants to merge 2 commits into
developfrom
copilot/sub-pr-20

Conversation

Copilot AI commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

Description

The conditional PropertyGroup for ImplicitUsings referenced frameworks (net5.0, net6.0, net7.0, net9.0) that were not in the TargetFrameworks list. This created a mismatch between the conditional checks and the actual build targets.

Updated the conditional to only check for net8.0 and net10.0 — the frameworks actually defined in TargetFrameworks that support implicit usings.

<!-- Before -->
<PropertyGroup Condition="
  '$(TargetFramework)' == 'net5.0' OR
  '$(TargetFramework)' == 'net6.0' OR
  '$(TargetFramework)' == 'net7.0' OR
  '$(TargetFramework)' == 'net8.0' OR
  '$(TargetFramework)' == 'net9.0' OR
  '$(TargetFramework)' == 'net10.0'
  ">

<!-- After -->
<PropertyGroup Condition="
  '$(TargetFramework)' == 'net8.0' OR
  '$(TargetFramework)' == 'net10.0'
  ">

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactor

How Has This Been Tested?

  • Built solution for all target frameworks (net462, netstandard2.0, net8.0, net10.0)
  • Code review passed
  • Security scan passed

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

N/A

Additional context

Addresses review feedback from PR #20 regarding conditional compilation alignment.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Copilot AI changed the title [WIP] Apply feedback from review discussion on develop PR Align conditional compilation directives with target frameworks Dec 27, 2025
Copilot AI requested a review from Chris-Wolfgang December 27, 2025 04:39
@Chris-Wolfgang Chris-Wolfgang deleted the copilot/sub-pr-20 branch December 28, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants