Develop by Chris-Wolfgang · Pull Request #14 · Chris-Wolfgang/Try-Pattern

Chris-Wolfgang · 2025-12-23T02:04:53Z

Description

Fixes/Complete # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Test A
Test B

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Screenshots (if applicable)

Additional context

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Refactored TryActionResult to use regular constructor instead of primary constructor parameters to: - Eliminate redundant property initializations that shadowed parameters - Ensure compatibility with older .NET frameworks (netstandard2.0, net462) - Maintain consistency with TryFuncResult pattern - Add proper XML documentation for the main constructor Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>

[WIP] Address feedback from review on initial implementation

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>

Remove redundant property initializations in TryActionResult

# Conflicts: # tests/TryPattern.Tests/TryPattern.Tests.csproj

…sualstudio-3.1.5'

…sualstudio-3.1.5' into develop # Conflicts: # tests/TryPattern.Tests/TryPattern.Tests.csproj

…est.Sdk-18.0.1' into develop # Conflicts: # tests/TryPattern.Tests/TryPattern.Tests.csproj

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>

Added TryActionResultTests.cs and TryFuncResultTests.cs to cover constructors and property assignments for both result classes. Tests include various scenarios (success, failure, exceptions) and multiple data types, using xUnit for comprehensive coverage and improved reliability.

Added TryPattern.Tests.csproj with xUnit and coverage tools for .NET 8.0. The test project references the main TryPattern project. Also removed the explicit <Version> tag from Wolfgang.TryPattern.csproj.

Added --output-file devskim-results.txt to the DevSkim analyze command in the workflow, ensuring scan results are saved to a file for easier access and review. No other workflow changes were made.

- Add continue-on-error to DevSkim scan to prevent workflow failure on findings - Exclude **/TestResults/** from scan via ignore-globs - Always show DevSkim results, with fallback message if no output - Set artifact upload to warn if results file is missing

Refactored Wolfgang.TryPattern.Tests.csproj to use conditional ItemGroups for framework-specific test dependencies, improving maintainability and compatibility. Updated TryFuncResult.cs constructor formatting for consistency (tabs instead of spaces) with no logic changes. Removed net9.0 from main project target frameworks; test project still targets net9.0. No functional code changes.

Added build-and-test-windows job to pr.yaml for building and testing on Windows with .NET 3.1–9.0, including code coverage and artifact upload. Also introduced build-and-test-macos job for .NET 5+ on macOS. Both jobs skip execution in the template repository.

- Refactored GitHub Actions to use matrix builds for Ubuntu, Windows, and macOS - Added .NET 10.0.x support across workflows - Improved error handling for label creation; added "dependencies" and "dotnet" labels - Enhanced DocFX workflow with build output verification - Separated build/test logic for Linux/macOS and Windows; coverage reporting now Windows-only - Improved artifact uploads with OS-specific naming - Security scanning now runs on all platforms with better reporting and failure detection

Major overhaul of pr.yaml GitHub Actions workflow: - Split into 3 gated stages: Linux (with 90% coverage gate), then Windows/macOS, then .NET Framework 4.x on Windows - Only proceed to next stage if previous passes - Coverage enforcement now on Linux, with clear per-module threshold - Artifacts for coverage and build outputs uploaded per stage - Security scan (DevSkim) runs in parallel with improved output - Workflow ignores docs/markdown changes for PR triggers - Improved modularity, logs, and error handling for maintainability

Added a step in the GitHub Actions workflow to install libssl1.1 on Ubuntu 22.04+ for the test-linux-core job. This ensures .NET Core 3.1 compatibility, as libssl1.1 is not included by default in newer Ubuntu versions.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Removed .NET Core 3.1 from the test matrix in the CI pipeline, so only net5.0 through net10.0 are tested. Added an informational step to echo a message on macOS runners explaining the skip of .NET Core 3.1 due to lack of ARM64 support, and clarifying that it is still tested on Linux and Windows.

Copilot · 2025-12-23T02:21:57Z

@Chris-Wolfgang I've opened a new pull request, #15, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-23T02:22:09Z

@Chris-Wolfgang I've opened a new pull request, #16, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-23T02:22:16Z

@Chris-Wolfgang I've opened a new pull request, #17, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-23T02:22:25Z

@Chris-Wolfgang I've opened a new pull request, #18, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2025-12-23T02:22:58Z

@Chris-Wolfgang I've opened a new pull request, #19, to work on those changes. Once the pull request is ready, I'll request review from you.

[WIP] Apply feedback from review on 'Develop' PR

[WIP] Address feedback from review on pull request #14

[WIP] Address feedback from PR #14 review comments

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 25 out of 28 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

tests/Wolfgang.TryPattern.Tests/TryActionAsyncTests.cs:109

Missing space after the comma. Should be "Assert.Equal(3, callCount);" for consistency with other assertions in the codebase.

Copilot · 2025-12-23T02:25:16Z

+            await action().ConfigureAwait(false);
+            return new TryActionResult(true, null);
+        }
+        catch(Exception ex)


Missing space after "catch" keyword. According to C# formatting standards, there should be a space between "catch" and the opening parenthesis.

Suggested change

catch(Exception ex)

catch (Exception ex)

[WIP] Address feedback on 'Develop' PR for improvements

…-time [WIP] WIP address feedback from review on develop PR

Copilot

Pull request overview

Copilot reviewed 25 out of 28 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

tests/Wolfgang.TryPattern.Tests/TryActionAsyncTests.cs:109

Missing space before the closing parenthesis. Should be "Assert.Equal(3, callCount);" for consistency with the rest of the codebase.

Updated Wolfgang.TryPattern.csproj to set the project version to 0.1.0-rc1, marking this build as a release candidate. No other changes were made.

Chris-Wolfgang and others added 30 commits December 20, 2025 14:02

Initial implementation

1aeaf91

Update tests/Wolfgang.TryPattern.Tests/Wolfgang.TryPattern.Tests.csproj

a242599

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Wolfgang.TryPattern/TryFuncResult.cs

07486e3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

5915c27

Initial plan

f431fe2

Merge pull request #7 from Chris-Wolfgang/copilot/sub-pr-6

e420f95

[WIP] Address feedback from review on initial implementation

Fix spacing consistency in TryActionResult

d7303ee

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>

Merge pull request #8 from Chris-Wolfgang/copilot/sub-pr-6-again

4afebcb

Remove redundant property initializations in TryActionResult

Merge branch 'main' into develop

6390d45

# Conflicts: # tests/TryPattern.Tests/TryPattern.Tests.csproj

Merge branch 'dependabot/nuget/tests/TryPattern.Tests/xunit.runner.vi…

4b89c09

…sualstudio-3.1.5'

Merge branch 'dependabot/nuget/tests/TryPattern.Tests/xunit.runner.vi…

93c1a98

…sualstudio-3.1.5' into develop # Conflicts: # tests/TryPattern.Tests/TryPattern.Tests.csproj

Merge branch 'dependabot/nuget/tests/TryPattern.Tests/Microsoft.NET.T…

3dce380

…est.Sdk-18.0.1' into develop # Conflicts: # tests/TryPattern.Tests/TryPattern.Tests.csproj

Merge branch 'main' of https://github.com/Chris-Wolfgang/Try-Pattern

6427eda

Merge branch 'main' into develop

de2aaf9

Initial plan

ad843d5

Add net9.0 and net10.0 target frameworks

03ea773

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>

Add test project and remove version from main csproj

95771c1

Added TryPattern.Tests.csproj with xUnit and coverage tools for .NET 8.0. The test project references the main TryPattern project. Also removed the explicit <Version> tag from Wolfgang.TryPattern.csproj.

Merge branch 'copilot/sub-pr-6' into develop

c53af26

Save DevSkim scan results to devskim-results.txt

a2fe5f3

Added --output-file devskim-results.txt to the DevSkim analyze command in the workflow, ensuring scan results are saved to a file for easier access and review. No other workflow changes were made.

Add OpenSSL 1.1 install step for .NET Core 3.1 on Ubuntu

fa58cf2

Added a step in the GitHub Actions workflow to install libssl1.1 on Ubuntu 22.04+ for the test-linux-core job. This ensures .NET Core 3.1 compatibility, as libssl1.1 is not included by default in newer Ubuntu versions.

Update tests/Wolfgang.TryPattern.Tests/TryFuncResultTests.cs

51e267f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/Wolfgang.TryPattern.Tests/TryFuncResultTests.cs

7cebc5c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

5f9d7b6

Copilot AI mentioned this pull request Dec 23, 2025

[WIP] Apply feedback from review on 'Develop' PR #15

Merged

7 tasks

Initial plan

e6b03b6

Copilot AI mentioned this pull request Dec 23, 2025

[WIP] Address feedback from review on pull request #14 #16

Merged

4 tasks

Initial plan

f108297

Copilot AI mentioned this pull request Dec 23, 2025

[WIP] Address feedback from PR #14 review comments #17

Merged

5 tasks

Initial plan

d5772c7

Copilot AI mentioned this pull request Dec 23, 2025

[WIP] Address feedback on 'Develop' PR for improvements #18

Merged

4 tasks

Update src/Wolfgang.TryPattern/TryActionResult.cs

6e466cf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings December 23, 2025 02:22

Initial plan

425ecef

Copilot AI mentioned this pull request Dec 23, 2025

[WIP] WIP address feedback from review on develop PR #19

Merged

4 tasks

Copilot started reviewing on behalf of Chris-Wolfgang December 23, 2025 02:23 View session

Chris-Wolfgang and others added 4 commits December 22, 2025 21:23

Merge pull request #15 from Chris-Wolfgang/copilot/sub-pr-14

343bdae

[WIP] Apply feedback from review on 'Develop' PR

Merge pull request #16 from Chris-Wolfgang/copilot/sub-pr-14-again

06c1b3f

[WIP] Address feedback from review on pull request #14

Merge pull request #17 from Chris-Wolfgang/copilot/sub-pr-14-another-one

36c3ef0

[WIP] Address feedback from PR #14 review comments

Fix XML documentation formatting in constructor comments

553d0db

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>

Copilot AI reviewed Dec 23, 2025

View reviewed changes

Chris-Wolfgang added 2 commits December 22, 2025 21:25

Merge pull request #18 from Chris-Wolfgang/copilot/sub-pr-14-yet-again

db62a44

[WIP] Address feedback on 'Develop' PR for improvements

Merge pull request #19 from Chris-Wolfgang/copilot/sub-pr-14-one-more…

2165d3f

…-time [WIP] WIP address feedback from review on develop PR

Chris-Wolfgang requested a review from Copilot December 23, 2025 02:26

Copilot started reviewing on behalf of Chris-Wolfgang December 23, 2025 02:26 View session

Copilot AI reviewed Dec 23, 2025

View reviewed changes

Bump version to 0.1.0-rc1 for release candidate

00e9187

Updated Wolfgang.TryPattern.csproj to set the project version to 0.1.0-rc1, marking this build as a release candidate. No other changes were made.

Chris-Wolfgang closed this Dec 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop#14

Develop#14
Chris-Wolfgang wants to merge 49 commits into
mainfrom
develop

Chris-Wolfgang commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Chris-Wolfgang commented Dec 23, 2025

Description

Type of change

How Has This Been Tested?

Checklist

Screenshots (if applicable)

Additional context

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI commented Dec 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants