Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions src/Wolfgang.TryPattern/Result.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,26 @@ protected Result
string? errorMessage
)
{
switch (succeeded)
if (succeeded && errorMessage != string.Empty)
{
case true when errorMessage != string.Empty:
throw new ArgumentException("A successful result cannot have an error message.", nameof(errorMessage));

case false when string.IsNullOrWhiteSpace(errorMessage):
throw new ArgumentException("A failed result must have an error message.", nameof(errorMessage));
throw new ArgumentException
(
"A successful result cannot have an error message.",
nameof(errorMessage)
);
}

default:
Succeeded = succeeded;
ErrorMessage = errorMessage;
break;
if (!succeeded && string.IsNullOrWhiteSpace(errorMessage))
{
throw new ArgumentException
(
"A failed result must have an error message.",
nameof(errorMessage)
);
}

Succeeded = succeeded;
ErrorMessage = errorMessage;
}


Expand All @@ -51,7 +58,7 @@ protected Result
/// Creates a failed Result with the specified error Message.
/// </summary>
/// <param name="errorMessage">The error message indicating the reason for failure.</param>
/// <exception cref="ArgumentException">errorMessage is null or empty</exception>
/// <exception cref="ArgumentException">errorMessage is null, empty, or whitespace</exception>
public static Result Failure(string errorMessage) =>
string.IsNullOrWhiteSpace(errorMessage)
? throw new ArgumentException("errorMessage cannot be empty", nameof(errorMessage))
Expand Down Expand Up @@ -302,7 +309,7 @@ public class Result<T> : Result
/// Creates a failed Result with the specified error message.
/// </summary>
/// <param name="errorMessage">The error message indicating the reason for failure.</param>
/// <exception cref="ArgumentException">errorMessage is null or empty</exception>
/// <exception cref="ArgumentException">errorMessage is null, empty, or whitespace</exception>
#if NET5_0_OR_GREATER
public static new Result<T?> Failure(string errorMessage) =>
string.IsNullOrWhiteSpace(errorMessage)
Expand Down
Loading