Bump dotnet-dependencies (supersedes #44) and drop duplicate test PackageReferences#47
Merged
Merged
Conversation
Includes all bumps from #44: - Meziantou.Analyzer 3.0.58 -> 3.0.63 (Directory.Build.props) - Microsoft.Extensions.Logging 10.0.2 -> 10.0.7 (src) - Microsoft.Extensions.Logging.Abstractions 10.0.2 -> 10.0.7 (src) - Microsoft.Extensions.DependencyInjection 10.0.7 added for net462 (src) - coverlet.collector 6.0.4 -> 10.0.0 (tests) Also drops the test csproj's redundant PackageReferences for Microsoft.Extensions.Logging and Microsoft.Extensions.DependencyInjection. The test project already gets both packages transitively via its ProjectReference to the src project (Microsoft.Extensions.Logging brings DependencyInjection along). The duplicate refs were the cause of the NU1605 downgrade error that blocked #44 — Dependabot bumped the src copies to 10.0.7 but left the test copies pinned at 10.0.2. Verified locally: dotnet restore is clean, dotnet build -c Release produces 0 warnings / 0 errors, dotnet test passes 52/52 across all runnable TFMs (net462-net481, net6.0-net10.0). net5.0 reports "no test available" which is the standard xunit-runner discovery quirk on that legacy TFM, not a regression. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
decb53c to
20b6ff9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions for the in-memory logger library and its unit tests, while simplifying the test project's package graph to avoid the package-downgrade failure that blocked the earlier Dependabot bump.
Changes:
- Bumped analyzer and runtime package versions, including
Meziantou.Analyzer,Microsoft.Extensions.Logging, andMicrosoft.Extensions.Logging.Abstractions. - Added an explicit
Microsoft.Extensions.DependencyInjectionreference for the library'snet462target. - Removed duplicate logging/DI package references from the unit test project and upgraded
coverlet.collector.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit.csproj |
Updates test dependencies and removes duplicate package references from the test project. |
src/Wolfgang.Extensions.Logging.InMemoryLogger/Wolfgang.Extensions.Logging.InMemoryLogger.csproj |
Bumps logging packages and adds a net462-specific DI dependency for the library project. |
Directory.Build.props |
Updates the shared analyzer version used across the repository. |
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #44. Includes every bump from the Dependabot PR plus a structural cleanup that fixes the NU1605 package-downgrade failure that was blocking it.
Bumps (same as #44):
Meziantou.Analyzer3.0.58 → 3.0.63 (Directory.Build.props)Microsoft.Extensions.Logging10.0.2 → 10.0.7 (src)Microsoft.Extensions.Logging.Abstractions10.0.2 → 10.0.7 (src)Microsoft.Extensions.DependencyInjection10.0.7 added for net462 (src)coverlet.collector6.0.4 → 10.0.0 (tests)Additional cleanup:
PackageReferenceentries forMicrosoft.Extensions.LoggingandMicrosoft.Extensions.DependencyInjection. The test project already gets both packages transitively via itsProjectReferenceto the src project.Test plan
dotnet restoreclean across all csprojs (no NU1605)dotnet build -c Releasesucceeds (0 warnings, 0 errors)dotnet test -c Releasepasses 52/52 across all runnable TFMs (net462-net481, net6.0-net10.0). net5.0 reports "no test is available" — known xunit-runner discovery quirk on that TFM, not a regression.🤖 Generated with Claude Code