Skip to content

Bump dotnet-dependencies (supersedes #44) and drop duplicate test PackageReferences#47

Merged
Chris-Wolfgang merged 1 commit into
mainfrom
deps/bump-dependencies-supersede-44
May 7, 2026
Merged

Bump dotnet-dependencies (supersedes #44) and drop duplicate test PackageReferences#47
Chris-Wolfgang merged 1 commit into
mainfrom
deps/bump-dependencies-supersede-44

Conversation

@Chris-Wolfgang
Copy link
Copy Markdown
Owner

Summary

Supersedes #44. Includes every bump from the Dependabot PR plus a structural cleanup that fixes the NU1605 package-downgrade failure that was blocking it.

Bumps (same as #44):

  • Meziantou.Analyzer 3.0.58 → 3.0.63 (Directory.Build.props)
  • Microsoft.Extensions.Logging 10.0.2 → 10.0.7 (src)
  • Microsoft.Extensions.Logging.Abstractions 10.0.2 → 10.0.7 (src)
  • Microsoft.Extensions.DependencyInjection 10.0.7 added for net462 (src)
  • coverlet.collector 6.0.4 → 10.0.0 (tests)

Additional cleanup:

  • Dropped the test csproj's duplicate PackageReference entries for Microsoft.Extensions.Logging and Microsoft.Extensions.DependencyInjection. The test project already gets both packages transitively via its ProjectReference to the src project.
  • That duplicate was the cause of the NU1605 on Bump the dotnet-dependencies group with 5 updates #44: Dependabot bumped the src copies to 10.0.7 but left the test copies pinned at 10.0.2 → restore detected a downgrade.
  • Removing the duplicate refs both fixes the immediate failure and prevents this footgun from recurring on future bumps.

Test plan

  • dotnet restore clean across all csprojs (no NU1605)
  • dotnet build -c Release succeeds (0 warnings, 0 errors)
  • dotnet test -c Release passes 52/52 across all runnable TFMs (net462-net481, net6.0-net10.0). net5.0 reports "no test is available" — known xunit-runner discovery quirk on that TFM, not a regression.

🤖 Generated with Claude Code

Includes all bumps from #44:
- Meziantou.Analyzer 3.0.58 -> 3.0.63 (Directory.Build.props)
- Microsoft.Extensions.Logging 10.0.2 -> 10.0.7 (src)
- Microsoft.Extensions.Logging.Abstractions 10.0.2 -> 10.0.7 (src)
- Microsoft.Extensions.DependencyInjection 10.0.7 added for net462 (src)
- coverlet.collector 6.0.4 -> 10.0.0 (tests)

Also drops the test csproj's redundant PackageReferences for
Microsoft.Extensions.Logging and Microsoft.Extensions.DependencyInjection.
The test project already gets both packages transitively via its
ProjectReference to the src project (Microsoft.Extensions.Logging brings
DependencyInjection along). The duplicate refs were the cause of the
NU1605 downgrade error that blocked #44 — Dependabot bumped the src
copies to 10.0.7 but left the test copies pinned at 10.0.2.

Verified locally: dotnet restore is clean, dotnet build -c Release
produces 0 warnings / 0 errors, dotnet test passes 52/52 across all
runnable TFMs (net462-net481, net6.0-net10.0). net5.0 reports "no test
available" which is the standard xunit-runner discovery quirk on that
legacy TFM, not a regression.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Chris-Wolfgang Chris-Wolfgang force-pushed the deps/bump-dependencies-supersede-44 branch from decb53c to 20b6ff9 Compare May 5, 2026 23:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependency versions for the in-memory logger library and its unit tests, while simplifying the test project's package graph to avoid the package-downgrade failure that blocked the earlier Dependabot bump.

Changes:

  • Bumped analyzer and runtime package versions, including Meziantou.Analyzer, Microsoft.Extensions.Logging, and Microsoft.Extensions.Logging.Abstractions.
  • Added an explicit Microsoft.Extensions.DependencyInjection reference for the library's net462 target.
  • Removed duplicate logging/DI package references from the unit test project and upgraded coverlet.collector.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit/Wolfgang.Extensions.Logging.InMemoryLogger.Tests.Unit.csproj Updates test dependencies and removes duplicate package references from the test project.
src/Wolfgang.Extensions.Logging.InMemoryLogger/Wolfgang.Extensions.Logging.InMemoryLogger.csproj Bumps logging packages and adds a net462-specific DI dependency for the library project.
Directory.Build.props Updates the shared analyzer version used across the repository.

Comment thread Directory.Build.props
@Chris-Wolfgang Chris-Wolfgang merged commit 85b88c6 into main May 7, 2026
8 of 9 checks passed
@Chris-Wolfgang Chris-Wolfgang deleted the deps/bump-dependencies-supersede-44 branch May 7, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants