Document ArgumentNullException on IsEmpty<T> and use named arg in example#85
Merged
Chris-Wolfgang merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
…mple Two CI fixes that together unblock the analyzer-bump PRs (#83 + #84) and main: - IEnumerableExtensions.cs:73 — IsEmpty<T> throws ArgumentNullException but was missing the <exception> doc tag (RCS1140). Added the tag matching the pattern used by every other throwing method in the file. - examples/IsNullOrEmpty.Example/Program.cs:23 — call to ProcessOrders(null) now uses a named argument (MA0003). This was a latent error masked by the earlier RCS1140 build failure. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes analyzer warnings on main by aligning XML docs with actual exceptions thrown and clarifying a null argument in an example project.
Changes:
- Documented
ArgumentNullExceptionforIsEmpty<T>via an XML<exception>tag. - Updated example usage to pass
nullwith an explicit named argument (orders: null) to satisfy analyzer rules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Wolfgang.Extensions.IEnumerable/IEnumerableExtensions.cs |
Adds missing XML exception documentation for IsEmpty<T> to match existing patterns and satisfy analyzers. |
examples/IsNullOrEmpty.Example/Program.cs |
Makes the null argument explicit with a named parameter in the example call site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes that together unblock the open analyzer-bump PRs (#83 Meziantou, #84 SonarAnalyzer) and resolve the failing build on `main`.
1. RCS1140 in `IEnumerableExtensions.cs:73`
`IsEmpty` throws `ArgumentNullException` but the XML doc lacked the `` tag. Added it, matching the pattern used by every other throwing method in this file (`ForEach`, `None`, `Do`, `Shuffle`).
2. MA0003 in `examples/IsNullOrEmpty.Example/Program.cs:23`
A latent error that was masked by RCS1140 stopping the build first. Changed `ProcessOrders(null)` → `ProcessOrders(orders: null)` to make the literal-null argument explicit.
Test plan
🤖 Generated with Claude Code