ci(pr): add ReSharper InspectCode job (canonical)#230
Open
Chris-Wolfgang wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ReSharper InspectCode GitHub Actions job to this repo’s gated PR workflow (pull_request_target) to run InspectCode in parallel with existing test stages, emit SARIF, upload results to GitHub Code Scanning, and fail the job only when SARIF contains level=error.
Changes:
- Introduces an
inspectcodejob that restores/builds Release, runsjb inspectcodeto generateinspect.sarif, and uploads it viaupload-sarif. - Adds a merge gate step that parses the SARIF and fails only when error-level findings are present.
Comment on lines
+264
to
+269
| - name: Checkout code | ||
| uses: actions/checkout@v7 | ||
| with: | ||
| ref: refs/pull/${{ github.event.pull_request.number }}/head | ||
| persist-credentials: false | ||
|
|
Comment on lines
+248
to
+251
| # SARIF uploads to GitHub Code Scanning (Security tab + inline PR | ||
| # annotations). `error`-severity findings fail the job; `warning`-severity | ||
| # surfaces in Code Scanning but doesn't fail (gated by --severity=WARNING | ||
| # filter). Tune the noise floor via .DotSettings at the repo root. |
…to Try-Pattern PR #248 canonical)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the canonical ReSharper InspectCode CI job (repo-template #427) to
pr.yaml.Additive — only the
inspectcode:job is inserted (afterdetect-projects, before the test stages). No existing job modified or removed (avoids the full-file-overwrite regression from Etl-DbClient #224).runs-on: ubuntu-latest;needs: detect-projects, guarded byhas-projects == 'true'.jb inspectcode→ SARIF → Code Scanning. Gate fails only onlevel=error.Proven green on AuditTrail, ETL-FixedWidth, System.Mail-Extensions. Protected file → merge via
merge-fleet-prs.ps1 -Branch chore/add-inspectcode.