Sync docfx.yaml from D20 canonical (inline root-redirect)#257
Merged
Conversation
The root index.html for gh-pages is now generated inline in the workflow as a meta-refresh → /versions/latest/ instead of being templated from .github/version-picker-template.html. Rationale (from D20's canonical comment): the in-page version picker (docfx_project/public/version-picker.js) handles version switching from any docs page now, so the root no longer needs to display a picker UI — a meta-refresh + JS fallback + <noscript> link is all that's needed. Inline beats template-file because the only dynamic piece is the page title. This is a sync-from-D20 only: byte-equivalent to D20's .github/workflows/docfx.yaml. Workflow is repo-agnostic — no hardcoded D20 references. `Detect .NET Projects` will fire on this PR. Admin-bypass merge. After merge, PR #256 will be updated to delete the now-unused .github/version-picker-template.html. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 6, 2026
D8 fleet sync: docfx.yaml from D20 canonical + delete picker-template.html
Chris-Wolfgang/ETL-Csv#89
Closed
Closed
This commit's parent (docfx.yaml D20-canonical sync) drops the only live reference to this file in docfx.yaml — the root index.html is now generated inline as a meta-refresh redirect instead of templated from this file. build-all-versions.yaml retains a reference (manual-rebuild path) — matches the rest of the fleet's canonical state; out of scope for this PR. Atomic with the docfx.yaml change so there is no deploy window where the workflow references a deleted file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protected-files PR — splits the workflow change for the D8 version-picker fanout out of #256 so admin-bypass only waives one file's review-thread enforcement.
docfx.yaml: sync from D20 canonical. The rootindex.htmlgeneration step is rewritten to emit an inline meta-refresh →/versions/latest/instead of templating from.github/version-picker-template.html.Rationale
The in-page version picker (the
public/version-picker.js+_appFooterscript injection landing in #256) handles version switching from every docs page. The root no longer needs its own picker UI — a meta-refresh + JS fallback +<noscript>link is sufficient.Pure sync from D20 (
Chris-Wolfgang/D20-Dice@main:.github/workflows/docfx.yaml) — no repo-specific values; the workflow reads the repo name from$env:GITHUB_REPOSITORYat runtime.Diff shape
.github/workflows/docfx.yaml| +136 / −32 lines (the inline HTML generation block + comments explaining why inline beats template-file).No other files touched.
Test plan
Detect .NET Projects❌ (expected — protected-file guard fires), other checks passFollow-up
.github/version-picker-template.html— no remaining live references indocfx.yamlafter this merges;build-all-versions.yamlretains the dead reference (same state as D20 / DateTime-Extensions / ICollection-Extensions — fleet-wide cleanup item, not in scope here).🤖 Generated with Claude Code