Skip to content

docfx: sync from repo-template (gh-pages bootstrap fix)#169

Closed
Chris-Wolfgang wants to merge 3 commits into
mainfrom
fix/docfx-bootstrap-gh-pages
Closed

docfx: sync from repo-template (gh-pages bootstrap fix)#169
Chris-Wolfgang wants to merge 3 commits into
mainfrom
fix/docfx-bootstrap-gh-pages

Conversation

@Chris-Wolfgang

Copy link
Copy Markdown
Owner

Summary

Sync .github/workflows/docfx.yaml from repo-template to pick up the gh-pages bootstrap fix from Chris-Wolfgang/repo-template#337.

What changed

The "Deploy docs to GitHub Pages" step had a latent bug: when the gh-pages branch did not yet exist on the remote, $WORK_DIR was created as a plain directory and the subsequent git add / diff --cached / commit / push failed with fatal: not a git repository. The fix initializes the directory as a git repo on gh-pages and adds the authenticated origin remote, so the existing add/commit/push works on a first-ever deploy. Cleanup also branches between git worktree remove (worktree path) and Remove-Item (fresh-repo path).

If gh-pages already exists in this repo (the common case), this change is a no-op at runtime — the bootstrap branch is only taken on a fresh repo.

Test plan

  • Workflow YAML lints / next docs deploy succeeds
  • (Optional) verify gh-pages is unaffected

Sync .github/workflows/docfx.yaml from canonical repo-template to pick up the bootstrap fix from Chris-Wolfgang/repo-template#337.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 9, 2026 17:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Syncs the DocFX GitHub Actions workflow with the upstream repo-template to fix first-time gh-pages deployments when the branch does not yet exist.

Changes:

  • Add a bootstrap path that initializes a gh-pages git repo in $WORK_DIR when the remote branch doesn’t exist.
  • Track whether a worktree was used and branch cleanup accordingly (git worktree remove vs Remove-Item).
  • Reset $LASTEXITCODE after cleanup to avoid cleanup-related failures.

Comment thread .github/workflows/docfx.yaml
Comment thread .github/workflows/docfx.yaml
Copilot AI review requested due to automatic review settings May 19, 2026 23:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@Chris-Wolfgang

Copy link
Copy Markdown
Owner Author

Superseded by PR #217 (D8 canonical refresh). The gh-pages bootstrap fix is included in the canonical docfx.yaml that #217 syncs from repo-template/main. Closing as no-longer-needed.

@Chris-Wolfgang Chris-Wolfgang deleted the fix/docfx-bootstrap-gh-pages branch June 6, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants