chore: harden GitHub Actions — pin CodeQL, explicit perms on release jobs (#99)#171
Merged
Conversation
- codeql.yaml: SHA-pin github/codeql-action/init and /analyze to v4.36.2 (8aad20d). Was @v4, which silently auto-tracks the latest v4.x. - release.yaml: declare explicit `permissions: {}` on validate-release, pack-and-validate, verify-docs-build, and publish-nuget. None of these jobs need GITHUB_TOKEN scopes (publish-nuget auths to NuGet via NUGET_API_KEY); making the no-privilege baseline explicit is defense-in-depth. Other workflows audited (benchmarks, build-all-versions, docfx, pr, stryker) already had appropriate top-level + job-level permissions and either SHA-pinned or first-party (actions/*) action references. Closes #99
Chris-Wolfgang
added a commit
that referenced
this pull request
Jun 26, 2026
Resolve conflicts from main's Dependabot bump (#163) by keeping vNext's forward-moving versions: - Wolfgang.Etl.Abstractions 0.14.1 (vNext) > 0.14.0 (main) - Wolfgang.Etl.TestKit / .Xunit 0.9.0 (vNext) > 0.8.1 (main) - release.yaml verify-docs-build keeps the permissions: {} added in #171 Verified: src builds Release clean (0 warnings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens GitHub Actions per the acceptance criteria in #99 (SHA-pin third-party actions; least-privilege permissions on every workflow).
Changes
github/codeql-action/initandgithub/codeql-action/analyzeto8aad20d(v4.36.2). Previously@v4, which silently floats to the latest v4.x patch.permissions: {}explicitly onvalidate-release,pack-and-validate,verify-docs-build, andpublish-nuget. None of these jobs needGITHUB_TOKENscopes (publish-nuget authenticates to NuGet viaNUGET_API_KEY), so the no-privilege baseline is now explicit instead of inherited.Audited and unchanged
benchmarks.yaml,build-all-versions.yaml,docfx.yaml,pr.yaml,stryker.yaml— already have appropriate top-levelpermissions: contents: readplus job-level overrides, and all third-party action references are either SHA-pinned (benchmark-action/github-action-benchmark@52576c9,peaceiris/actions-gh-pages@84c30a8,softprops/action-gh-release@718ea10) or first-partyactions/*.pull_request_targetusage in pr.yaml is paired with the protected-config guard pattern; secrets scan runs before checkout. No changes needed.Heads-up
Workflow files are in the protected-files guard set, so this PR may need the maintainer-bypass merge path or a
protected-file-pr-splitat merge time.Closes #99