Dev#4
Merged
Merged
Conversation
# Conflicts: # ETL-Test-Kit.slnx # README.md # scripts/Setup-BranchRuleset.ps1
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares Wolfgang.Etl.TestKit for NuGet distribution by adding package icon assets, wiring up package metadata in the .csproj, and updating the repository README to point to the published NuGet package.
Changes:
- Added
.ico/.pngicon assets for use in the repo and NuGet package. - Updated
Wolfgang.Etl.TestKit.csprojwithPackageReadmeFile,PackageIcon, and packing rules for README/icon. - Updated
README.mdto link to the NuGet package and removed template placeholders.
Reviewed changes
Copilot reviewed 2 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Wolfgang.Etl.TestKit/testkit_icon.ico | Adds project icon asset (ICO) under the library project directory. |
| src/Wolfgang.Etl.TestKit/Wolfgang.Etl.TestKit.csproj | Adds NuGet metadata for readme/icon and includes icon content entries. |
| assets/testkit_icon_32.png | Adds 32px PNG icon asset. |
| assets/testkit_icon_64.png | Adds 64px PNG icon asset. |
| assets/testkit_icon_128.png | Adds 128px PNG icon asset (referenced as PackageIcon). |
| assets/testkit_icon_256.png | Adds 256px PNG icon asset. |
| assets/testkit_icon_512.png | Adds 512px PNG icon asset. |
| assets/testkit_icon.ico | Adds an ICO icon asset under assets/. |
| README.md | Updates NuGet link and removes placeholder sections (currently leaving empty headers). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added icons, updated readme and prepped solution for nuget