fix: build Report timing via the 0.18.1 constructor (net6/net7 MissingMethodException) - #255
Merged
Merged
Conversation
…gMethodException) The doubles surfaced Report.StartedAt/Elapsed/TotalItemCount via the object-initializer (init) form. On .NET 6/7 a consumer loads TestKit's netstandard2.0 assembly but resolves Abstractions' modern assembly at runtime, so the init-setter IsExternalInit modreq did not match -> MissingMethodException. Use the plain Report(int, DateTimeOffset?, TimeSpan, int?) constructor added in Abstractions 0.18.1, whose signature is identical across every TFM. Bump the Abstractions reference 0.18.0 -> 0.18.1. Verified: the previously-failing net6.0 tests pass against Abstractions 0.18.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 29, 2026
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Into
vNextfor 0.11.0 — fixes the Stage 1 / net6.0 failure on #254.Problem
The doubles surfaced
Reporttiming via the object-initializer (init) form. On .NET 6/7, a consumer loads TestKit'snetstandard2.0assembly but resolves Abstractions' modern assembly at runtime, so theinitsetter'sIsExternalInitmodreq didn't match →MissingMethodException: Report.set_StartedAt. (net462/net8/net10 matched, so they were green.)Fix
Reportvia the newReport(int, DateTimeOffset?, TimeSpan, int?)constructor (Abstractions 0.18.1) instead of the initializer. A plain ctor has no modreq, so its signature is identical on every TFM. Behavior is unchanged (same values, same validation).Wolfgang.Etl.Abstractionsreference0.18.0 → 0.18.1.Verified
Clean restore against the published NuGet 0.18.1: the previously-failing net6.0 suite passes 194/194 (was 175 pass / 19 fail).
Once merged, #254's
net6.0stage goes green.