test(xunit): CurrentErrorItemCount default + no-over-read (#49) contract tests - #253
Merged
Merged
Conversation
…contract tests - CurrentErrorItemCount_defaults_to_zero on all three base contract classes (the new 0.18 counter, parallel to the #248 skipped-count default-zero tests). - No-over-read contract tests (#49) on all three bases: a stage must stop pulling from its source once MaximumItemCount is reached (<= M+1 reads) or the run is cancelled, and a pre-cancelled token must read nothing. An internal PullCounter wraps the source. Extractors opt in via a new virtual CreateSutOverSource factory (no-op by default), wired for the TestExtractor doubles. - CHANGELOG: document the #248 counter tests and #49. +12 tests. Full multi-TFM build clean; 295 xunit tests pass on net10.0 and net48. Closes #49 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 29, 2026
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Into
vNextfor 0.11.0. Adds contract-test coverage on all three base classes:CurrentErrorItemCount_defaults_to_zero— the new 0.18 counter, parallel to the Add CurrentSkippedItemCount contract tests to TestKit.Xunit #248 skipped-count default-zero tests. Free coverage for every downstream consumer.MaximumItemCountis reached (≤ M+1 reads) or the run is cancelled, and a pre-cancelled token must read nothing. An internalPullCounterwraps the source and counts pulls. The extractor opts in via a new virtualCreateSutOverSourcefactory (a no-op by default, so no existing consumer breaks; extractors whose source isn't an injectable sequence simply skip these three tests). Wired for theTestExtractordoubles.+12 tests. Full multi-TFM build clean; 295 xunit tests pass on both net10.0 and net48.
Closes #49. (Fires when
vNextmerges tomain.)