Skip to content

fix(version-picker): correct comment about auto-select behavior #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris-Wolfgang merged 1 commit into from
Jul 24, 2026
Merged

fix(version-picker): correct comment about auto-select behavior #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docfx_project/public/version-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,11 @@
// on /versions/latest/. On every other page the highest-
// numbered v* entry already represents the latest release
// and surfacing both is redundant; on /versions/latest/ we
// NEED `latest` in the list because otherwise the picker
// would show no selected option and the reader would have
// no way to know which version they are viewing.
// NEED `latest` in the list because without it the browser auto-
// selects the first concrete version (whichever v* is top of
// the list), and choosing that same value doesn't fire
// `change`, so the reader can't navigate away to the
// concrete-version URL.
if (v.version === 'latest' && currentVersion !== 'latest') return;
var opt = document.createElement('option');
opt.value = v.url;
Expand Down