build: enable PackageValidation ABI gate (#125) - #225
Merged
Conversation
Enables SDK PackageValidation on both packable projects with baseline 0.10.0 (the last published NuGet version). At pack time it downloads the baseline and validates the current build's ABI, failing the pack (and thus release.yaml) if a non-major bump introduces a binary/behavioural break the PublicAPI.Shipped.txt diff doesn't catch. Verified: both projects pack clean against the 0.10.0 baseline. Matches the fleet-canonical approach (ETL-FixedWidth, D20-Dice). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The actions-audit (#143) was failing every open PR on findings that aren't actionable: - actionlint tripped on info-level shellcheck nits (SC2012 'use find not ls', SC2035 'use ./*glob*') in the canonical pr.yaml. Set SHELLCHECK_OPTS to --severity=warning so it gates on warning+ (real issues), not style nits. - zizmor flagged error[dangerous-triggers] on pr.yaml's pull_request_target. That is the intentional *gated* pattern (runs from trusted main, checks out PR refs, re-fetches config from main). Added a documented dangerous-triggers ignore for pr.yaml to .zizmor.yml and wired --config .zizmor.yml into the zizmor step (it is not auto-discovered). - Enabling the config also activates the existing unpinned-uses:hash-pin policy, which then flagged pr.yaml's three remaining tag-pinned actions (checkout@v7, setup-dotnet@v5, upload-sarif@v4). SHA-pinned them to the repo canonical commits (also fixing a real SHA-pin-convention gap). Verified locally: zizmor --config at high severity reports no findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Addresses the zizmor 'mismatched version comment' finding on #234: the pin e0647621 is a real codeql-action commit (v4.37.2) but not the one the v4 tag points to, so the hash-pin comment-match check flags it. Re-pin every codeql-action reference (init / analyze / upload-sarif across pr, codeql, actions-audit, scorecard, semgrep) to e4fba868 — the actual commit v4 resolves to (verified via the GitHub tags API) — so each # v4 comment now matches. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 29, 2026
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the SDK's built-in PackageValidation (which wraps Microsoft.DotNet.ApiCompat) on both packable projects, baseline 0.10.0 (last published NuGet version).
How it satisfies #125
The AC asks for an
api-compatrelease step that validates ABI against the previous NuGet version. PackageValidation does exactly this, at pack time — sorelease.yaml(which packs) gets the gate automatically, on every pack, with no bespoke workflow step:PublicAPI.Shipped.txtdiff misses.CompatibilitySuppressions.xml.dotnet packfails NU1102).Verified
Both projects pack clean against the 0.10.0 baseline locally (no CP0xxx breaks). Matches the fleet-canonical setup (ETL-FixedWidth, D20-Dice).
Closes #125 when the vNext cycle merges to main.
🤖 Generated with Claude Code