Skip to content

fix(docs): version-picker shows selected option on /versions/latest/ #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris-Wolfgang merged 3 commits into from
Jul 20, 2026
Merged

fix(docs): version-picker shows selected option on /versions/latest/ #204

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5edede7
fix(docs): version-picker shows selected option on /versions/latest/
Chris-Wolfgang Jul 14, 2026
406e2b1
Gate `latest` in picker on regex-match, not on default value
Chris-Wolfgang Jul 20, 2026
82728ef
Merge branch 'main' into fix/version-picker-latest-select
Chris-Wolfgang Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 14 additions & 35 deletions docfx_project/public/version-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,40 +49,17 @@
}

function renderPicker(versions) {
// Detect the currently-viewed version from the URL.
var currentVersion = 'latest';
// Detect the currently-viewed version from the URL. Starts as null and
// is only set when the URL actually matches /versions/<v>/. Root and
// other non-versioned pages leave it null — that way the `latest`
// alias entry stays out of the picker except on /versions/latest/,
// and no option gets pre-selected when we can't identify the version.
var currentVersion = null;
var m = window.location.pathname.match(/\/versions\/([^\/]+)(?:\/|$)/);
if (m) {
currentVersion = m[1];
}

// If we're on /versions/latest/, resolve 'latest' to the concrete
// version it points to (matching the `latest` entry's url against
// the versioned entries). Without this resolution, the browser
// auto-selects the first option in the dropdown — which is usually
// the same concrete version 'latest' aliases — and picking that
// option doesn't fire `change`, leaving the user unable to navigate
// away from /versions/latest/ to the equivalent concrete-version
// URL via the picker.
if (currentVersion === 'latest') {
var latestEntry = null;
for (var i = 0; i < versions.length; i++) {
if (versions[i] && versions[i].version === 'latest') {
latestEntry = versions[i];
break;
}
}
if (latestEntry && latestEntry.url) {
for (var j = 0; j < versions.length; j++) {
var v = versions[j];
if (v && v.version !== 'latest' && v.url === latestEntry.url) {
currentVersion = v.version;
break;
}
}
}
}

// Build the <select>.
var select = document.createElement('select');
select.className = 'wolfgang-version-picker';
Expand Down Expand Up @@ -113,12 +90,14 @@
var optionCount = 0;
versions.forEach(function (v) {
if (!v || !v.version || !v.url) return;
// Skip the "latest" alias — the highest-numbered v* entry
// already represents the latest release; surfacing both is
// redundant in the picker. versions.json keeps the "latest"
// entry so other consumers (links, scripts) can still
// resolve it.
if (v.version === 'latest') return;
// Skip the "latest" alias EXCEPT when the reader is actually
// on /versions/latest/. On every other page the highest-
// numbered v* entry already represents the latest release
// and surfacing both is redundant; on /versions/latest/ we
// NEED `latest` in the list because otherwise the picker
// would show no selected option and the reader would have
// no way to know which version they are viewing.
if (v.version === 'latest' && currentVersion !== 'latest') return;
Comment thread
Chris-Wolfgang marked this conversation as resolved.
var opt = document.createElement('option');
opt.value = v.url;
opt.textContent = v.version;
Expand Down