refactor: FaultyExtractor async-hop + double style consistency#183
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure source cleanup from code review — no public-API change (zero PublicAPI.txt edits required).
Changes
FaultyExtractor.ExtractWorkerAsyncasync-hop placement. Movedawait Task.Yield()from after the loop/finally (where it sat below theThrowAfterCompletionthrow and was therefore unreachable on theThrowAfterCompletionandMaximumItemCountyield breakpaths) to the top of the method, right after the initialtoken.ThrowIfCancellationRequested()— mirroringTestExtractor.ExtractWorkerAsync. The comment now accurately states it runs on every exit path. The old misleading trailing comment is removed.(and)on their own lines) inTestLoader,FaultyLoader,TestTransformer,FaultyTransformer— matching the extractors.CreateProgressReport()uses target-typednew(CurrentItemCount)across all doubles (wasnew Report(...)in the four loaders/transformers).TestLoader.GetCollectedItems()snapshot switched from_buffer.ToList()to_buffer.ToArray()so both loaders use the same cheaper fixed-length snapshot; return type unchanged (IReadOnlyList<T>?).TestTransformer/FaultyTransformerparameterless-ctor<summary>from "default production timer" (inaccurate — the ctor sets no timer) to "default base-class progress timer".Verification
dotnet build ETL-Test-Kit.slnx -c Release→ 0 warnings / 0 errors, all TFMs (net462; netstandard2.0; net481; net8.0; net10.0).-c Release -f net8.0→ all green (355 = 233 Xunit contract + 122 unit).🤖 Generated with Claude Code