fix: restore <AssemblyVersion>1.0.0.0</AssemblyVersion> across all src csprojs (C4 post-mortem)#108
Merged
Merged
Conversation
…> in src/Wolfgang.Etl.TestKit/Wolfgang.Etl.TestKit.csproj (C4 fix)
…> in src/Wolfgang.Etl.TestKit.Xunit/Wolfgang.Etl.TestKit.Xunit.csproj (C4 fix)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores stable assembly binding metadata for the two shippable src projects, aligning their .NET Framework-facing assembly identity with the binding-stability rationale described in the PR.
Changes:
- Adds fixed
<AssemblyVersion>1.0.0.0</AssemblyVersion>to both source project files. - Replaces hardcoded
<FileVersion>1.0.0</FileVersion>with a prerelease-safe value derived from<Version>. - Documents the intended AssemblyVersion/FileVersion behavior inline in each project file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Wolfgang.Etl.TestKit/Wolfgang.Etl.TestKit.csproj |
Pins assembly version and derives file version from package version. |
src/Wolfgang.Etl.TestKit.Xunit/Wolfgang.Etl.TestKit.Xunit.csproj |
Applies the same versioning metadata pattern to the Xunit companion package. |
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
<AssemblyVersion>1.0.0.0</AssemblyVersion>+ adds prerelease-safe<FileVersion>(via regex-strip property function) to every src csproj in this multi-project repo.Why
The original C4 fanout dropped
<AssemblyVersion>on the rationale that the hardcoded1.0.0was "stale" relative to released package versions. But that staleness was the correct binding-stability behaviour for libraries that ship anet462TFM. With SDK-derived AssemblyVersion, every minor/patch release ships a different binding identity, breaking .NET Framework consumers without a binding redirect.DateTime-Extensions v1.3.0 publicly shipped this regression. This repo has not yet released the regression (the C4 drop is on
canonical-unprotectedbut hasn't reachedmain). Landing this fix neutralises the footgun across all src csprojs before any merge to main.Csproj changes (per src project)
The regex-strip property function ensures prerelease
<Version>values (e.g.,1.2.3-beta.1) still produce a 4-part numericAssemblyFileVersion(1.2.3.0) — verified locally on peer repos.Standard pattern (NodaTime / Newtonsoft / AutoMapper)
AssemblyVersion1.0.0.0AssemblyFileVersion<Version>.0Version(NuGet)<Version>Tracked in the per-repo-release-pilot skill as the corrected Phase 2 step 1.