test: remove dead IntRecord test POCO (C8, #102)#183
Merged
Conversation
Static analysis of the test and benchmark projects for dead code. The only finding: the `IntRecord` record in FixedWidthProgressTests.cs was never referenced anywhere (no test, no [MemberData]/[ClassData], no nameof) — a speculative "available for any tests that need a minimal record type" helper that was never adopted. Its file contained nothing else, so the whole file is removed. The benchmark project has no dead code: every [Benchmark] class is discovered by BenchmarkSwitcher.FromAssembly, both POCOs are used, and all [GlobalSetup]/ [Params]/private helpers are referenced. Verified: 303/303 tests still pass, Release build clean. Closes #102 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #102 (C8: Eliminate dead code in test and benchmark projects).
Static reference analysis of both non-product projects:
IntRecordrecord inFixedWidthProgressTests.cs. Grep across the whole repo found zero references (no test uses it, no[MemberData]/[ClassData]/nameof). Its own XML doc — "Available for any tests that need a minimal record type" — confirms a speculative helper that was never adopted. The file held nothing else, so it is deleted entirely. (Progress/timer behavior is exercised through theWolfgang.Etl.TestKit.Xunitcontract base classes, not local files.)[Benchmark]class is discovered byBenchmarkSwitcher.FromAssembly, both POCOs (BenchmarkRecord,BenchmarkRecordWithDate) are used, and all[GlobalSetup]/[GlobalCleanup]/[Params]/private helpers are referenced.Verified: 303/303 tests pass, Release build clean.
Stacking
Based on
chore/bump-testkit-0.9.0(#177).