Skip to content

Fix macOS CI: replace GNU-only grep -P with POSIX-compatible awk/grep -E in Stage 3 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris-Wolfgang merged 11 commits into from
Mar 12, 2026
+18 −2
Merged

Fix macOS CI: replace GNU-only grep -P with POSIX-compatible awk/grep -E in Stage 3 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5118dec
Initial plan
Copilot Mar 12, 2026
ef7892b
Add coverlet.collector v6.0.4 to test project for CI coverage generation
Copilot Mar 12, 2026
fbe995e
Initial plan
Copilot Mar 12, 2026
d43bcf2
fix: replace grep -oP with POSIX-compatible awk/grep -oE in pr.yaml
Copilot Mar 12, 2026
8aa74cf
fix: revert Stage 1/2 grep -oP changes; keep only Stage 3 macOS fix
Copilot Mar 12, 2026
fbc13ae
Merge branch 'copilot/fix-coverage-threshold-step' into copilot/add-c…
Chris-Wolfgang Mar 12, 2026
946c8ae
Initial plan
Copilot Mar 12, 2026
87bc45c
Fix macOS grep -P incompatibility in coverage threshold enforcement
Copilot Mar 12, 2026
7d66b76
Revert Stage 1 coverage check to original grep -oP; keep awk fix for …
Copilot Mar 12, 2026
ae09452
Merge branch 'copilot/add-coverlet-collector-reference' into copilot/…
Chris-Wolfgang Mar 12, 2026
5db3174
Merge pull request #78 from Chris-Wolfgang/copilot/fix-grep-issues-in…
Chris-Wolfgang Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,8 +703,8 @@ jobs:

while IFS= read -r line; do
if echo "$line" | grep -qE '^[^ ]+.*[0-9]+%$' && ! echo "$line" | grep -q '^Summary'; then
MODULE=$(echo "$line" | grep -oP '^[^ ]+')
PERCENT=$(echo "$line" | grep -oP '[0-9]+(?=%)' | tail -1)
MODULE=$(echo "$line" | awk '{print $1}')
PERCENT=$(echo "$line" | grep -oE '[0-9]+%' | tail -1 | tr -d '%')
echo "Checking module: '$MODULE' - Coverage: ${PERCENT}%"
if [ "$PERCENT" -lt "$THRESHOLD" ]; then
echo " ❌ FAIL: Below ${THRESHOLD}% threshold"
Expand Down
16 changes: 16 additions & 0 deletions tests/Wolfgang.Etl.Abstractions.Tests.Unit/Wolfgang.Etl.Abstractions.Tests.Unit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,22 @@
<PackageReference Include="System.Linq.AsyncEnumerable" Version="10.0.2" />
</ItemGroup>

<!-- coverlet.collector is required by dotnet test to generate coverage.cobertura.xml when
using XPlat Code Coverage collection. It must be referenced in the test project for
net5.0 and greater; .NET Framework and netcoreapp3.1 targets do not participate in
coverage collection. -->
<ItemGroup Condition="'$(TargetFramework)' == 'net5.0' OR
'$(TargetFramework)' == 'net6.0' OR
'$(TargetFramework)' == 'net7.0' OR
'$(TargetFramework)' == 'net8.0' OR
'$(TargetFramework)' == 'net9.0' OR
'$(TargetFramework)' == 'net10.0'">
<PackageReference Include="coverlet.collector" Version="6.0.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\Wolfgang.Etl.Abstractions\Wolfgang.Etl.Abstractions.csproj" />
</ItemGroup>
Expand Down
Loading