Merged
Conversation
Added new (skipped) unit tests for progress callbacks in ExtractorBaseTests, LoaderBaseTests, and TransformerBaseTests, including scenarios with cancellation tokens. Replaced two TransformerBaseTests with similar skipped versions. Made minor formatting adjustments to the project file without changing metadata.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is primarily a formatting/cleanup pass across the repo (removing BOMs, normalizing whitespace), with two functional/meta changes: excluding several skipped/flaky progress-callback tests from code coverage and updating the Wolfgang.Etl.Abstractions package target frameworks (dropping netstandard2.0/netstandard2.1).
Changes:
- Add
[ExcludeFromCodeCoverage]to several skipped “timing issues” unit tests around progress callbacks. - Remove
netstandard2.0andnetstandard2.1fromWolfgang.Etl.Abstractionsmulti-targeting. - Normalize whitespace/BOM and minor formatting in interfaces and example apps.
Reviewed changes
Copilot reviewed 80 out of 93 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Wolfgang.Etl.Abstractions.Tests.Unit/BaseClassTests/TransformerBaseTests.cs | Exclude skipped/flaky progress-related tests from coverage. |
| tests/Wolfgang.Etl.Abstractions.Tests.Unit/BaseClassTests/LoaderBaseTests.cs | Exclude skipped/flaky progress-related tests from coverage. |
| tests/Wolfgang.Etl.Abstractions.Tests.Unit/BaseClassTests/ExtractorBaseTests.cs | Exclude skipped/flaky progress-related tests from coverage. |
| src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj | Remove netstandard2.0/netstandard2.1 from target frameworks; minor formatting. |
| src/Wolfgang.Etl.Abstractions/ITransformWithProgressAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/ITransformWithProgressAndCancellationAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/ITransformWithCancellationAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/ITransformAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/ILoadWithProgressAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/ILoadWithProgressAndCancellationAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/ILoadWithCancellationAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/ILoadAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/IExtractWithProgressAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/IExtractWithProgressAndCancellationAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/IExtractWithCancellationAsync.cs | BOM/whitespace normalization. |
| src/Wolfgang.Etl.Abstractions/IExtractAsync.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example6-ReducingDuplicateCode/Program.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example6-ReducingDuplicateCode/EtlProgress.cs | Minor formatting (blank line). |
| examples/Net8.0/Example6-ReducingDuplicateCode/ETL/IntToStringTransformer.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example6-ReducingDuplicateCode/ETL/FibonacciExtractor.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example6-ReducingDuplicateCode/ETL/ConsoleLoader.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example6-ReducingDuplicateCode/ConsoleColors.cs | Minor formatting (blank line). |
| examples/Net8.0/Example5a-ExtractorWithProgressAndCancellation/Program.cs | Minor formatting (blank line). |
| examples/Net8.0/Example5a-ExtractorWithProgressAndCancellation/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net8.0/Example5a-ExtractorWithProgressAndCancellation/ETL/FibonacciExtractor.cs | Whitespace normalization. |
| examples/Net8.0/Example5a-ExtractorWithProgressAndCancellation/ETL/ConsoleLoader.cs | Whitespace normalization. |
| examples/Net8.0/Example4c-WithLoaderProgress/Program.cs | Minor formatting (blank line). |
| examples/Net8.0/Example4c-WithLoaderProgress/ETL/IntToStringTransformer.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example4c-WithLoaderProgress/ETL/FibonacciExtractor.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example4c-WithLoaderProgress/ETL/ConsoleLoader.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example4b-WithTransformerProgress/Program.cs | Minor formatting (blank line). |
| examples/Net8.0/Example4b-WithTransformerProgress/ETL/IntToStringTransformer.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example4b-WithTransformerProgress/ETL/FibonacciExtractor.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example4b-WithTransformerProgress/ETL/ConsoleLoader.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example4a-WithExtractorProgress/Program.cs | Minor formatting (blank line). |
| examples/Net8.0/Example4a-WithExtractorProgress/ETL/IntToStringTransformer.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example4a-WithExtractorProgress/ETL/FibonacciExtractor.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example4a-WithExtractorProgress/ETL/ConsoleLoader.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example3-WithGracefulCancellation/Program.cs | Minor formatting (blank line). |
| examples/Net8.0/Example3-WithGracefulCancellation/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net8.0/Example3-WithGracefulCancellation/ETL/FibonacciExtractor.cs | Minor formatting (blank line). |
| examples/Net8.0/Example3-WithGracefulCancellation/ETL/ConsoleLoader.cs | Minor formatting (blank line). |
| examples/Net8.0/Example2-WithCancellationToken/Program.cs | Minor formatting (blank line). |
| examples/Net8.0/Example2-WithCancellationToken/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net8.0/Example2-WithCancellationToken/ETL/FibonacciExtractor.cs | Minor formatting (blank line). |
| examples/Net8.0/Example2-WithCancellationToken/ETL/ConsoleLoader.cs | Minor formatting (blank line). |
| examples/Net8.0/Example1-BasicETL/Program.cs | Whitespace normalization. |
| examples/Net8.0/Example1-BasicETL/ETL/IntToStringTransformer.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example1-BasicETL/ETL/FibonacciExtractor.cs | BOM/whitespace normalization. |
| examples/Net8.0/Example1-BasicETL/ETL/ConsoleLoader.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example6-ReducingDuplicateCode/Properties/AssemblyInfo.cs | BOM removal. |
| examples/Net4.8/Example6-ReducingDuplicateCode/Program.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example6-ReducingDuplicateCode/ETL/IntToStringTransformer.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example6-ReducingDuplicateCode/ETL/FibonacciExtractor.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example6-ReducingDuplicateCode/ETL/ConsoleLoader.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example6-ReducingDuplicateCode/ConsoleColors.cs | Whitespace normalization. |
| examples/Net4.8/Example5a-ExtractorWithProgressAndCancellation/Properties/AssemblyInfo.cs | BOM removal. |
| examples/Net4.8/Example5a-ExtractorWithProgressAndCancellation/Program.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example5a-ExtractorWithProgressAndCancellation/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net4.8/Example5a-ExtractorWithProgressAndCancellation/ETL/FibonacciExtractor.cs | Whitespace normalization. |
| examples/Net4.8/Example5a-ExtractorWithProgressAndCancellation/ETL/ConsoleLoader.cs | Whitespace normalization. |
| examples/Net4.8/Example5a-ExtractorWithProgressAndCancellation/ConsoleColors.cs | Whitespace normalization. |
| examples/Net4.8/Example4c-WithLoaderProgress/Properties/AssemblyInfo.cs | BOM removal. |
| examples/Net4.8/Example4c-WithLoaderProgress/Program.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example4c-WithLoaderProgress/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net4.8/Example4c-WithLoaderProgress/ETL/FibonacciExtractor.cs | Whitespace normalization. |
| examples/Net4.8/Example4c-WithLoaderProgress/ETL/ConsoleLoader.cs | Whitespace normalization. |
| examples/Net4.8/Example4c-WithLoaderProgress/ConsoleColors.cs | Whitespace normalization. |
| examples/Net4.8/Example4b-WithTransformerProgress/Properties/AssemblyInfo.cs | BOM removal. |
| examples/Net4.8/Example4b-WithTransformerProgress/Program.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example4b-WithTransformerProgress/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net4.8/Example4b-WithTransformerProgress/ETL/FibonacciExtractor.cs | Whitespace normalization. |
| examples/Net4.8/Example4b-WithTransformerProgress/ETL/ConsoleLoader.cs | Whitespace normalization. |
| examples/Net4.8/Example4b-WithTransformerProgress/ConsoleColors.cs | Whitespace normalization. |
| examples/Net4.8/Example4a-WithExtractorProgress/Properties/AssemblyInfo.cs | BOM removal. |
| examples/Net4.8/Example4a-WithExtractorProgress/Program.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example4a-WithExtractorProgress/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net4.8/Example4a-WithExtractorProgress/ETL/FibonacciExtractor.cs | Whitespace normalization. |
| examples/Net4.8/Example4a-WithExtractorProgress/ETL/ConsoleLoader.cs | Whitespace normalization. |
| examples/Net4.8/Example4a-WithExtractorProgress/ConsoleColors.cs | Whitespace normalization. |
| examples/Net4.8/Example3-WithGracefulCancellation/Properties/AssemblyInfo.cs | BOM removal. |
| examples/Net4.8/Example3-WithGracefulCancellation/Program.cs | Whitespace normalization. |
| examples/Net4.8/Example3-WithGracefulCancellation/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net4.8/Example3-WithGracefulCancellation/ETL/ConsoleLoader.cs | Whitespace normalization. |
| examples/Net4.8/Example3-WithGracefulCancellation/ConsoleColors.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example2-WithCancellationToken/Properties/AssemblyInfo.cs | BOM removal. |
| examples/Net4.8/Example2-WithCancellationToken/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net4.8/Example2-WithCancellationToken/ETL/ConsoleLoader.cs | Whitespace normalization. |
| examples/Net4.8/Example2-WithCancellationToken/ConsoleColors.cs | BOM/whitespace normalization. |
| examples/Net4.8/Example1-BasicETL/Properties/AssemblyInfo.cs | BOM removal. |
| examples/Net4.8/Example1-BasicETL/Program.cs | Whitespace normalization. |
| examples/Net4.8/Example1-BasicETL/ETL/IntToStringTransformer.cs | Whitespace normalization. |
| examples/Net4.8/Example1-BasicETL/ETL/ConsoleLoader.cs | Whitespace normalization. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed netstandard20 and netstandard2.1 because .net framework 4.6.2 - 4.8.1, net core 3.1, and .net 5-10 are already in the build.
Excluded skipped tests from code coverage until can get them fixed
Type of change
Please delete options that are not relevant.