Repository navigation
ci(aot): run the AOT smoke check on every PR, not just src/ changes - #713
Merged
Merged
Conversation
#657 makes 'PublishAot linux-x64 + run' a required status check. A workflow skipped by a pull_request paths: filter reports nothing at all, so with the filter in place every docs-, config- or workflow-only PR would block forever waiting for it. The job takes ~40s. Refs #657 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 12, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prerequisite for #657, which asks for
PublishAot linux-x64 + runto be added to themainruleset's required status checks.aot.yamlcurrently filterspull_requestbypaths:(src/**, the AotSmoke project, and the workflow file itself). A workflow skipped by apaths:filter reports nothing, not even "skipped". If the check were required with that filter in place, every docs-only, config-only or workflow-only PR would sit in "Waiting for status to be reported" forever. That includes most Dependabot PRs and every protected-file-only PR. ETL-SqlBulkCopy hit exactly this, and fixed it in its PR #279.This PR removes the
pull_requestpaths:filter and adds aDO NOT ADD ONEcomment explaining why. Thepushandworkflow_dispatchtriggers are unchanged. The job took 38 s on the latestmainrun (38281508442).aot.yamlis a protected file, so this PR changes only that file.Refs #657. This PR does not close it; the ruleset change still has to be made afterwards.
After merge (Chris)
Add the check to ruleset 14452864 ("Protect main branch"). Agents can't change rulesets, so this step is yours:
Verified
actionlintpasses andzizmor --offlinereports no findings.PublishAot linux-x64 + runeven though nosrc/file changed. That is the end-to-end proof the filter is gone.🤖 Generated with Claude Code