Repository navigation
ci(scorecard): move the SARIF filter out of the publishing job - #709
Merged
Merged
Conversation
scorecard.dev rejects published results when the job running ossf/scorecard-action has any run: step, so every publish since the filter step was added returned 400 and the badge went stale. The analysis job now holds only uses: steps (checkout, Scorecard, upload-artifact); a new upload job downloads the SARIF, runs the unchanged filter, and uploads to Code Scanning. Closes #705 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 12, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #705. scorecard.dev rejects published results when the job running
ossf/scorecard-actionhas arun:step. The Filter suppressed findings from SARIF step lives in that job, so every publish fails with a 400 while the run still shows green.analysiskeeps onlyuses:steps: checkout, Scorecard, andupload-artifactofresults.sarif.security-events: writeis removed from this job;id-token: writeandcontents: readstay.upload(new,needs: analysis, withsecurity-events: writeandcontents: read) checks out withpersist-credentials: falseso the alert fingerprints stay stable, downloads the artifact, runs the filter step unchanged, then runsupload-sarif.This uses the repo's existing pins:
upload-artifactv7.0.1 anddownload-artifactv8.0.1. The change mirrors Chris-Wolfgang/Log-Compressor#297, which is merged and publishing.scorecard.yamlis a protected file, so this PR is offmainand changes only that file. It is deliberately not part of the #706 → #707 → #708 stack.Verified
actionlint .github/workflows/scorecard.yamlpasses.analysisis auses:step.Not verified yet
Scorecard runs on push to
main, not on PRs. After merge, check two things:mainrun's log has noerror sending scorecard resultsline.https://api.scorecard.dev/projects/github.com/Chris-Wolfgang/ETL-Abstractionsreturns a current date.🤖 Generated with Claude Code