Repository navigation
fix(changelog): analyzer config and PublicAPI baselines under src/ never need a fragment - #647
Merged
Merged
Conversation
…ver need a fragment Takes repo-template#630. `check` counted every path matching ^src/, so a PR touching only a nested .editorconfig (or a .globalconfig / .ruleset / .DotSettings, or a PublicAPI.*.txt baseline) demanded a changelog fragment - which such a PR cannot carry, because the protected-file guard fails a PR that mixes a protected file with anything else. Those paths are now excluded and reported separately; code and csproj under src/ still require a fragment or the no-changelog label. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fan-out of Chris-Wolfgang/repo-template#630; this repository's
scripts/changelog.ps1was byte-identical to the template's, so this is a clean take of the fixed file.checkclassified a PR by path (^src/), so a PR whose only change is a nestedsrc/…/.editorconfigwas told to add a changelog fragment — which it cannot:changelog/unreleased/*.mdis unprotected, so adding one turns a protected-file-only PR into a mixed PR and the protected-file guard fails it unbypassably. The only way through was theno-changeloglabel on a change that never needed a note.Now excluded from the
src/set (they cannot change what the library does for a consumer): a nested.editorconfig, any*.globalconfig/*.ruleset/*.DotSettings, and thePublicAPI.Shipped.txt/PublicAPI.Unshipped.txtbaselines. Everything else undersrc/still requires a fragment or the label; the count line reports the ignored files separately.Verified upstream with 11 regex cases (near-misses like
EditorConfigReader.csandPublicAPI.Shipped.txt.templatestill count) and an end-to-end scratch-repo run: config-only passes, config + a new.csfails with exit 1, code + fragment passes.scripts/changelog.ps1is protected → configuration-only PR. The matchingchangelog/unreleased/README.mdwording rides the next template sync.🤖 Generated with Claude Code