Bump Microsoft.Bcl.AsyncInterfaces from 10.0.2 to 10.0.3 and fix DevSkim workflow#54
Conversation
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
05e8b40
into
dependabot/nuget/examples/Net4.8/Example1-BasicETL/multi-9eecbbe2d8
There was a problem hiding this comment.
Pull request overview
This PR fixes a DevSkim CI workflow failure by adding the --output-file parameter to the DevSkim analyze command. The workflow was attempting to read devskim-results.txt in subsequent steps, but the file wasn't being created because the scan command wasn't configured to write to it. The PR description also mentions a dependency update for Microsoft.Bcl.AsyncInterfaces from 10.0.2 to 10.0.3, but no dependency file changes are included in this PR.
Changes:
- Added
--output-file devskim-results.txtparameter to the DevSkim analyze command in the PR workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Run DevSkim Security Scan (Save output) | ||
| run: devskim analyze --source-code . --file-format text -E --ignore-rule-ids DS176209 --ignore-globs "**/api/**,**/CoverageReport/**" | ||
| run: devskim analyze --source-code . --file-format text -E --ignore-rule-ids DS176209 --ignore-globs "**/api/**,**/CoverageReport/**" --output-file devskim-results.txt |
There was a problem hiding this comment.
The PR description states that Microsoft.Bcl.AsyncInterfaces was updated from 10.0.2 to 10.0.3, but there are no changes to any dependency files in this PR. The codebase already shows version 10.0.3 in all relevant files (src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj and all example packages.config files). Either the dependency update was already applied in a previous commit, or the PR description should be updated to reflect only the DevSkim workflow fix.
Description
Dependency update for Microsoft.Bcl.AsyncInterfaces from 10.0.2 to 10.0.3.
Fixed DevSkim CI workflow failure caused by missing output file parameter. The workflow step was configured to read
devskim-results.txtbut the scan command wasn't writing to it, causing the build to fail with "No such file or directory".Changed:
--output-file devskim-results.txtto DevSkim analyze command in.github/workflows/pr.yamlType of change
How Has This Been Tested?
Checklist
Screenshots (if applicable)
N/A
Additional context
The DevSkim security scanning tool requires the
--output-fileparameter to write results to a file. Without it, output goes to stdout only, making the file unavailable for the "Show DevSkim Results in Summary" and artifact upload steps.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.