chore(publicapi): record the 18 synthesized members of Report and EtlPipelineProgress - #479
Merged
Chris-Wolfgang merged 2 commits intoSep 17, 2026
Merged
Conversation
…elineProgress The 18 compiler-synthesized members of the two shipped records (<Clone>$, copy ctor, Deconstruct, Equals ×2, GetHashCode, ToString, PrintMembers, EqualityContract, == / !=) have shipped unrecorded since the records were introduced because RS0016 is muzzled by the blanket analyzer severity (#459). Harvested by raising RS0016 to warning on this project alone across all 11 target frameworks (identical set on every one) and appended to PublicAPI.Shipped.txt — they are already public, so Shipped, not Unshipped. RS0017 accepts the <Clone>$ lines in the form RS0016 emits on PublicApiAnalyzers 5.6.0 (the blocker recorded in Chris-Wolfgang/ETL-Csv#263 no longer reproduces). ErrorPolicies, TestKit and TestKit.Xunit report nothing. Refs #459. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Backfills the shipped API baseline for 18 synthesized members of Report and EtlPipelineProgress.
Changes:
- Adds all 18 synthesized record members.
- Makes no runtime or package changes.
File summaries
| File | Summary |
|---|---|
src/Wolfgang.Etl.Abstractions/PublicAPI.Shipped.txt |
Records synthesized APIs for both shipped records. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Chris-Wolfgang
deleted the
chore/publicapi-backfill-synthesized-members
branch
September 17, 2026 23:24
Chris-Wolfgang
added a commit
that referenced
this pull request
Sep 18, 2026
… fails the build) The blanket dotnet_analyzer_diagnostic.severity = suggestion silenced RS0016 and RS0037, so public additions shipped unrecorded (#459). Explicit warning severities below the blanket line win; warning is an error in Release builds. Proven: an undeclared public class now fails with RS0016; main and release/0.25.0 both build clean under the rule (#479 backfilled the surface). Closes #459. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Chris-Wolfgang
added a commit
that referenced
this pull request
Sep 18, 2026
… fails the build) (#482) The blanket dotnet_analyzer_diagnostic.severity = suggestion silenced RS0016 and RS0037, so public additions shipped unrecorded (#459). Explicit warning severities below the blanket line win; warning is an error in Release builds. Proven: an undeclared public class now fails with RS0016; main and release/0.25.0 both build clean under the rule (#479 backfilled the surface). Closes #459. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backfills
PublicAPI.Shipped.txtforWolfgang.Etl.Abstractionswith the 18 compiler-synthesized members of the two shipped records —ReportandEtlPipelineProgress— (<Clone>$, copy ctor,Deconstruct,Equals×2,GetHashCode,ToString,PrintMembers,EqualityContract,==/!=). They have shipped unrecorded since the records were introduced because RS0016 is muzzled by the blanket analyzer severity (#459); the options records added in 0.24 were hand-recorded and are complete.Method: RS0016 raised to
warningon this project only (temporary.editorconfig— a globalconfig loses to the repo's blanket line),--no-incrementalRelease build across all 11 target frameworks: the reported set is identical on every one. Entries appended to Shipped (they are already public), file order otherwise untouched. ErrorPolicies, TestKit and TestKit.Xunit report nothing.Note for #459 / Chris-Wolfgang/ETL-Csv#263: on PublicApiAnalyzers 5.6.0 the recorded
<Clone>$lines pass RS0017 on every TFM (a bogus entry still fails, so the rule is live) — the blocker that kept RS0016 unenforceable no longer reproduces. Raising RS0016 for real is the next step (protected.editorconfig, separate PR).Verification
After the change: RS0016 raised again → 0 reported; plain Release build → 0 warnings, 0 errors (no RS0017).
Metadata only — no code, no package change; rides the next release.
🤖 Generated with Claude Code