Release 0.23.3 - #430
Merged
Merged
Release 0.23.3#430
Conversation
…est-gate VSTHRD003 The SonarAnalyzer 10.32 bump (#416) added rule S8969 ("Null-forgiving operators should not be redundant"), which flagged 20 redundant `x!.member` uses across the test/contract-base code (e.g. `final!.ErrorItemCount`, `PeekStartedAt!.Value` — the `!` has no effect where the value is already non-null). Removed the redundant `!` at each site. Release (TWAE) build stays clean, which proves each was genuinely redundant (a needed `!` would surface a CS86xx nullable warning). Also suppressed one VSTHRD003 (await of a foreign task) in GatedSourceAsync — awaiting a TaskCompletionSource used to gate the test is intentional — with a narrow inline #pragma rather than a per-instance dismissal, so it survives line shifts. No behaviour or public-API change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ll-forgiving chore: remove redundant null-forgiving operators (S8969) + test-gate VSTHRD003
Patch release: the S8969 redundant null-forgiving cleanup + VSTHRD003 pragma (#426) and the CI github-actions bump (#424). No public API change. <Version> 0.23.2 -> 0.23.3. Baseline already 0.23.2 (last published, reconciled from main). PackageValidation passes against the live 0.23.2. Touches protected Directory.Build.props — merge via admin-bypass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chore(release): 0.23.3 — version + CHANGELOG
Contributor
There was a problem hiding this comment.
BenchmarkDotNet
Details
| Benchmark suite | Current: a37a4d5 | Previous: 0e84394 | Ratio |
|---|---|---|---|
Wolfgang.Etl.Abstractions.Benchmarks.ExtractorBenchmarks.Extract_NoProgress(RecordCount: 1000) |
32068.14725748698 ns (± 150.0114068111003) |
32193.258728027344 ns (± 656.9553182984853) |
1.00 |
Wolfgang.Etl.Abstractions.Benchmarks.ExtractorBenchmarks.Extract_WithProgress(RecordCount: 1000) |
36012.71960449219 ns (± 77.32191561344811) |
35698.08504231771 ns (± 137.5391388325523) |
1.01 |
Wolfgang.Etl.Abstractions.Benchmarks.ExtractorBenchmarks.Extract_NoProgress(RecordCount: 100000) |
3110600.5481770835 ns (± 4598.763890121206) |
3162559.00390625 ns (± 4527.364080952584) |
0.98 |
Wolfgang.Etl.Abstractions.Benchmarks.ExtractorBenchmarks.Extract_WithProgress(RecordCount: 100000) |
3346772.49609375 ns (± 2499.1681120197236) |
3376237.1223958335 ns (± 8282.149531846426) |
0.99 |
Wolfgang.Etl.Abstractions.Benchmarks.PipelineBenchmarks.FluentPipeline(RecordCount: 1000) |
29587.68584696452 ns (± 95.89763075954077) |
29751.945119222004 ns (± 155.089617437925) |
0.99 |
Wolfgang.Etl.Abstractions.Benchmarks.PipelineBenchmarks.ManualComposition(RecordCount: 1000) |
29793.025517781574 ns (± 202.4212185207263) |
28961.55145263672 ns (± 120.576117905684) |
1.03 |
Wolfgang.Etl.Abstractions.Benchmarks.PipelineBenchmarks.BaseClassComposition(RecordCount: 1000) |
83059.04030354817 ns (± 253.5200708238782) |
81686.82682291667 ns (± 163.44912601062592) |
1.02 |
Wolfgang.Etl.Abstractions.Benchmarks.PipelineBenchmarks.FluentPipeline(RecordCount: 100000) |
2961801.62890625 ns (± 6689.097312142974) |
2875148.3125 ns (± 6159.261124918694) |
1.03 |
Wolfgang.Etl.Abstractions.Benchmarks.PipelineBenchmarks.ManualComposition(RecordCount: 100000) |
2929335.0065104165 ns (± 1287.6101335628227) |
2932113.671875 ns (± 10276.737699830326) |
1.00 |
Wolfgang.Etl.Abstractions.Benchmarks.PipelineBenchmarks.BaseClassComposition(RecordCount: 100000) |
7734809.338541667 ns (± 7050.708825845719) |
8228873.229166667 ns (± 16100.182434317143) |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.23.3 — patch (no public API change). Merge after the protected bundle #429, so the guard passes and full CI runs.
Contents (since 0.23.2)
!operators (SonarAnalyzer 10.32 S8969) + one inline VSTHRD003 pragma. No behaviour/API change.This PR is also the alert-reduction verification
It runs ReSharper InspectCode on
main(viapull_request_target), so its scan will:Read that check before tagging.
Order
0.23.3-> release.yaml -> NuGet publish.🤖 Generated with Claude Code