Skip to content

Clarify .NET SDK requirements for test execution#37

Merged
Chris-Wolfgang merged 1 commit intogithub-folder-changesfrom
copilot/sub-pr-27-one-more-time
Dec 19, 2025
Merged

Clarify .NET SDK requirements for test execution#37
Chris-Wolfgang merged 1 commit intogithub-folder-changesfrom
copilot/sub-pr-27-one-more-time

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 18, 2025

Description

Addressed review question about whether older .NET SDK versions (5.0.x, 6.0.x, 7.0.x) are needed in the workflow.

The test project explicitly targets net5.0, net6.0, and net7.0 in addition to net8.0 and net9.0. Running tests for each target framework requires the corresponding SDK to be installed. The workflows correctly install all necessary SDKs.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactor

How Has This Been Tested?

  • Verified test project targets multiple .NET versions (net5.0, net6.0, net7.0, net8.0, net9.0, net10.0)
  • Confirmed CI workflows build and test against these frameworks
  • Validated that SDK versions match test project requirements

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

N/A

Additional context

No code changes were required. This was a clarification response to a review question about workflow SDK configuration.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update tests based on feedback for .github folder Clarify .NET SDK requirements for test execution Dec 18, 2025
Copilot AI requested a review from Chris-Wolfgang December 18, 2025 21:54
@Chris-Wolfgang
Copy link
Copy Markdown
Owner

@copilot Do we need to install older 4.x frameworks for testing?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Dec 18, 2025

@copilot Do we need to install older 4.x frameworks for testing?

No, .NET Framework 4.x doesn't need to be installed. It comes pre-installed on Windows runners. The modern .NET SDK (5.0+) that's already being installed can build and test .NET Framework projects on Windows. The workflows correctly handle this: Windows builds all targets including net462/net472/net48/net481, while Linux/macOS exclude .NET Framework targets since they only run on Windows.

@Chris-Wolfgang Chris-Wolfgang marked this pull request as ready for review December 19, 2025 01:42
@Chris-Wolfgang Chris-Wolfgang merged commit 4210005 into github-folder-changes Dec 19, 2025
2 checks passed
@Chris-Wolfgang Chris-Wolfgang deleted the copilot/sub-pr-27-one-more-time branch December 19, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants