Skip to content

Clarify .NET SDK requirements for test project target frameworks#35

Merged
Chris-Wolfgang merged 1 commit intogithub-folder-changesfrom
copilot/sub-pr-27-another-one
Dec 18, 2025
Merged

Clarify .NET SDK requirements for test project target frameworks#35
Chris-Wolfgang merged 1 commit intogithub-folder-changesfrom
copilot/sub-pr-27-another-one

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 18, 2025

Description

Addresses review feedback on PR #27 regarding whether .NET 5.0.x, 6.0.x, and 7.0.x SDKs are necessary for running tests.

Finding: These SDKs are required. The test project (Wolfgang.Etl.Abstractions.Tests.Unit.csproj) explicitly targets net5.0, net6.0, and net7.0 alongside other frameworks. Each target framework requires its corresponding SDK to build and execute tests.

Removing these SDK versions from the CI workflow would require first removing the corresponding target frameworks from the test project's TargetFrameworks property.

Type of change

  • Documentation update

How Has This Been Tested?

  • Verified test project target frameworks in .csproj file
  • Confirmed SDK requirements match workflow configuration

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

N/A

Additional context

No code changes were made. This PR documents the analysis confirming the current CI workflow configuration is correct for the test project's multi-targeting requirements.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on .github folder updates Clarify .NET SDK requirements for test project target frameworks Dec 18, 2025
Copilot AI requested a review from Chris-Wolfgang December 18, 2025 21:53
@Chris-Wolfgang Chris-Wolfgang marked this pull request as ready for review December 18, 2025 21:55
@Chris-Wolfgang Chris-Wolfgang merged commit bfb6324 into github-folder-changes Dec 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants