Clarify .NET SDK requirements for test project target frameworks#35
Merged
Chris-Wolfgang merged 1 commit intogithub-folder-changesfrom Dec 18, 2025
Merged
Conversation
Copilot
AI
changed the title
[WIP] Address feedback on .github folder updates
Clarify .NET SDK requirements for test project target frameworks
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses review feedback on PR #27 regarding whether .NET 5.0.x, 6.0.x, and 7.0.x SDKs are necessary for running tests.
Finding: These SDKs are required. The test project (
Wolfgang.Etl.Abstractions.Tests.Unit.csproj) explicitly targetsnet5.0,net6.0, andnet7.0alongside other frameworks. Each target framework requires its corresponding SDK to build and execute tests.Removing these SDK versions from the CI workflow would require first removing the corresponding target frameworks from the test project's
TargetFrameworksproperty.Type of change
How Has This Been Tested?
.csprojfileChecklist
Screenshots (if applicable)
N/A
Additional context
No code changes were made. This PR documents the analysis confirming the current CI workflow configuration is correct for the test project's multi-targeting requirements.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.