Dependency-free WrapWorkerExecution retry seam on the base classes (#94) - #333
Merged
Conversation
…ses (#94) Add a protected virtual WrapWorkerExecution hook to ExtractorBase, LoaderBase, and TransformerBase, wrapped around every worker invocation (both the no-progress and with-progress paths). The default implementation is a no-op, so behaviour is unchanged; an override receives a re-invocable worker factory (call it again to retry a transient failure) and stream-level semantics are documented on the method. Kept dependency-free per the 0.20.0 decision (Option 1): Abstractions stays zero-dep and roots 8 downstream packages, so no Polly dependency here. A ready-made Polly integration will ship as a separate opt-in Wolfgang.Etl.Polly package (#332). - 13 new RetrySeamTests (default no-op, seam-invoked-once on both paths, factory re-invocability, genuine transient-failure recovery, null guard) across all 3 bases. 426 unit tests pass; Stryker 100.00% (0 survivors) on the full project. - PublicAPI.Unshipped updated with the 3 protected virtual entries (RS0017-validated). - CHANGELOG [Unreleased] Added entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 28, 2026
This was referenced Jul 30, 2026
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94.
Summary
Adds a dependency-free retry seam —
protected virtual WrapWorkerExecution(...)— toExtractorBase,LoaderBase, andTransformerBase, wrapped around every worker invocation (both the no-progress and with-progress paths). The default is a no-op, so existing behaviour is unchanged; an override runs the worker through a retry / resilience strategy.The override receives a re-invocable worker factory — calling it again produces a fresh worker run, which is what lets a strategy retry a transient failure.
Design decision — Option 1 (dep-free), per maintainer
The issue recommended Option A (inject Polly's
ResiliencePipeline), but Abstractions is intentionally zero third-party runtime dependencies and roots 8 downstream packages, so taking a Polly dependency here would force it on the whole fleet. Chosen approach: ship only the seam; a ready-made Polly integration lands as a separate opt-inWolfgang.Etl.Pollypackage — tracked in #332.Scope
OnItemErrorhook later). Counter-reset and source re-enumeration semantics are documented on each seam.Verification
RetrySeamTests: default no-op, seam-invoked-once on both paths, factory re-invocability, genuine transient-failure recovery, null guard — across all 3 bases).Notes for release-prep (not in this PR)
vNext-plus-one(the 0.20.0 line). The version bump 0.19.0 → 0.20.0 andPackageValidationBaselineVersion→ 0.19.0 are deferred to 0.20.0 release-prep, gated on 0.19.0 publishing. The[Unreleased]section here still carries the Widen EtlPipelineProgress counters from int to long (overflow-safe record counts) #285/Mutation survivors (10) — kill these to raise the score #328 entries inherited from the vNext fork; those get reconciled when main (0.19.0) merges into vNext-plus-one.