Skip to content

Fix test results path pattern in release workflow#32

Merged
Chris-Wolfgang merged 2 commits intogithub-folder-changesfrom
copilot/sub-pr-27-one-more-time
Dec 18, 2025
Merged

Fix test results path pattern in release workflow#32
Chris-Wolfgang merged 2 commits intogithub-folder-changesfrom
copilot/sub-pr-27-one-more-time

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 18, 2025

Description

The release workflow's test results upload was using an incorrect path pattern that wouldn't match .NET test output structure. The pattern '**/TestResults*.trx' only matches files named like "TestResults*.trx", not files within a TestResults directory hierarchy.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactor

Changes

Test command: Added --logger "trx" --results-directory "./TestResults" to generate TRX files in the expected location

Upload path: Changed from '**/TestResults*.trx' to 'TestResults/**/*.trx' to match the actual .NET output structure: TestResults/[guid]/[test-results-file].trx

Before:

dotnet test "$proj" --no-build --configuration Release
# ...
path: '**/TestResults*.trx'

After:

dotnet test "$proj" --no-build --configuration Release --logger "trx" --results-directory "./TestResults"
# ...
path: 'TestResults/**/*.trx'

How Has This Been Tested?

  • YAML syntax validation
  • Code review passed

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

N/A

Additional context

This fix ensures test results are properly collected and uploaded as artifacts across all OS platforms (ubuntu-latest, windows-latest, macos-latest) in the release workflow.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on .github folder updates Fix test results path pattern in release workflow Dec 18, 2025
Copilot AI requested a review from Chris-Wolfgang December 18, 2025 00:37
@Chris-Wolfgang Chris-Wolfgang marked this pull request as ready for review December 18, 2025 01:13
@Chris-Wolfgang Chris-Wolfgang merged commit 1e3023a into github-folder-changes Dec 18, 2025
@Chris-Wolfgang Chris-Wolfgang deleted the copilot/sub-pr-27-one-more-time branch December 18, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants