ci(pr): add ReSharper InspectCode job (canonical) - #267
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ReSharper InspectCode job to the PR CI workflow (pr.yaml) to produce SARIF output and upload it to GitHub Code Scanning, with merge gating only on error-level findings.
Changes:
- Introduces a new
inspectcodejob that runs afterdetect-projectsand in parallel with test stages. - Installs ReSharper GlobalTools and runs
jb inspectcodeto generateinspect.sarif. - Uploads SARIF via
github/codeql-action/upload-sarif@v4and fails the job when SARIF containslevel=="error"results.
…to Try-Pattern PR #248 canonical)
The InspectCode job installed only the 10.0.x SDK but builds the whole solution, which multi-targets out-of-support TFMs (netcoreapp3.1, net5.0, net6.0, net7.0). Their targeting packs are not guaranteed to restore under a lone 10.0.x SDK, so the solution build could fail even when the test stages (which install 3.1.x-10.0.x) pass. Mirror those stages so InspectCode compiles the exact same TFM set. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 18, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the canonical ReSharper InspectCode CI job (repo-template #427) to
pr.yaml.Additive — only the
inspectcode:job is inserted (afterdetect-projects, before the test stages). No existing job modified or removed (avoids the full-file-overwrite regression from Etl-DbClient #224).runs-on: ubuntu-latest;needs: detect-projects, guarded byhas-projects == 'true'.jb inspectcode→ SARIF → Code Scanning. Gate fails only onlevel=error.Proven green on AuditTrail, ETL-FixedWidth, System.Mail-Extensions. Protected file → merge via
merge-fleet-prs.ps1 -Branch chore/add-inspectcode.