tier1: recover orphaned doc fixes into vNext (CONTRIBUTING header + #235)#236
Merged
Conversation
…tch list Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- LoaderBase / TransformerBase: <example> code referenced 'MaxItemCount', which is not a member; the property is 'MaximumItemCount' (4 occurrences). - SystemProgressTimer: <remarks> told users to return a 'ManualProgressTimer' from CreateProgressTimer, but no such type exists. Point at a custom IProgressTimer implementation instead (now a resolvable <see cref>). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tier1: fix XML-doc inaccuracies from code-review pass (#161)
This was referenced Jun 20, 2026
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers tier-1 work that was orphaned in
tier1/markdown-auditafter #234 merged an early snapshot to vNext.When #234 (markdown audit) merged into vNext, two later commits on this branch never made it back:
### The 7 Analyzers→### The 8 Analyzersheader fix (the item-8 body landed via tier1: Markdown audit — drop stale REPO-INSTRUCTIONS, fix analyzer list (#172) #234, but the header correction did not).LoaderBase/TransformerBase<example>referenced the non-existentMaxItemCount(→MaximumItemCount), andSystemProgressTimerdoc pointed at a non-existentManualProgressTimer(→ resolvableIProgressTimercref).vNext currently still has the buggy
MaxItemCountexamples and the "7 Analyzers" header, so this needs to land before v0.13.1 ships. The branch already has vNext merged in, so this is conflict-free.Net diff: CONTRIBUTING.md + 3 src XML-doc files. No code-behavior change.
Closes #161 · Part of: #154