Add W favicon to docs (docfx)#229
Merged
Merged
Conversation
Chris-Wolfgang
added a commit
that referenced
this pull request
Jun 19, 2026
Resolves 2 conflict files by taking main's (canonical) version:
- .github/workflows/docfx.yaml — 3 hunks. vNext was behind on:
- The `env: GITHUB_REPOSITORY: ...` derive that lets the versions.json
preservation guard work under workflow_call (main's PR #229/#230).
- The hardened PowerShell error handling in the existing-versions
fetch (distinguishes 404 from other failures more carefully,
drops the PS-5-only `-UseBasicParsing` flag).
- The inlined root-redirect HTML — replaces the external
`.github/version-picker-template.html` indirection (main's
PR #195 "canonical/d8-inline-root-redirect"). The template file
is deleted by this merge.
- docs/DOCFX-VERSION-PICKER.md — add/add. Main's 256-line version
documents the inlined-HTML approach; vNext's 210-line version
still described the template file. Taking main's keeps the doc
internally consistent with the workflow change above.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replicates repo-template PR #413. Adds the canonical W favicon to this repo's DocFX site so the browser tab shows a recognizable Wolfgang branding mark.
Design
White W (Segoe UI Black) on a purple
#4a1e9erounded tile with a lighter#7c5cf6rim so the tile edge stays visible against dark themes. Self-contained — no webfont dependency.Files added
docfx_project/favicon.svg— primary, scalable, linked via the modern templatedocfx_project/favicon.ico— multi-size legacy fallback (16/32/48)docfx_project/apple-touch-icon.png— iOS home-screen (180×180)Wiring (
docfx_project/docfx.json)resource.fileslist so they ship in_site_appFaviconPath: "favicon.svg"added underglobalMetadata— DocFX modern template's native favicon hook (emits<link rel="icon">automatically)Note:
_appFaviconPathlinks only the SVG (which all modern browsers honour). The.icoand apple-touch assets ship in the site for completeness but aren't auto-linked in<head>.No bypass required
docfx_project/*is unprotected — should merge as a normal PR once CI is green.