Skip to content

.editorconfig: sync from canonical#145

Merged
Chris-Wolfgang merged 1 commit into
mainfrom
chore/sync-editorconfig-from-canonical
May 2, 2026
Merged

.editorconfig: sync from canonical#145
Chris-Wolfgang merged 1 commit into
mainfrom
chore/sync-editorconfig-from-canonical

Conversation

@Chris-Wolfgang

Copy link
Copy Markdown
Owner

Summary

Syncs .editorconfig to current canonical (repo-template main).

Brings this repo up to date with the canonical changes that landed since the last .editorconfig sync, including:

  • repo-template#329: RS0030.severity = none in [tests/**/*.cs] and [benchmarks/**/*.cs] (the prior warning setting was promoted back to error by TreatWarningsAsErrors in Release).
  • repo-template#330: 7 modern C# style suggestions (using directive placement, method group conversion, primary constructors, System.Threading.Lock, compound assignment, expression-bodied operators, operator placement when wrapping). All at suggestion/silent severity — non-blocking.

Expected CI behavior

PR Checks v3 (Gated)Detect protected configuration file changes will fail by design. .editorconfig is a protected file; the PR workflow gates non-Dependabot changes via that step. CI cannot pass automated checks as-is.

Merge path: maintainer manual review + admin merge (or temporary ruleset bypass), after locally verifying the diff matches repo-template/.editorconfig byte-for-byte.

Test plan

  • .editorconfig content matches canonical byte-for-byte (verified locally with diff before push)
  • Maintainer reviews diff against repo-template/.editorconfig
  • Admin merge

🤖 Generated with Claude Code

Picks up canonical changes since this repo's last .editorconfig sync,
including repo-template#329 (RS0030 = none in tests/benchmarks) and
repo-template#330 (modern C# style suggestions at suggestion/silent
severity).

.editorconfig is a protected file; the PR workflow's protected-files
guard will fail by design. Requires maintainer admin merge after
verifying the diff matches canonical byte-for-byte.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 2, 2026 00:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs this repository’s .editorconfig with the current canonical version from repo-template/main, updating analyzer severities for tests/benchmarks and adding several modern C# style preferences at non-blocking severities.

Changes:

  • Add modern C# style preferences (e.g., using placement, method group conversion, primary constructors, System.Threading.Lock, compound assignment, expression-bodied operators, operator placement).
  • Relax RS0030 (Banned API Analyzer) to none in tests/**/*.cs and benchmarks/**/*.cs to avoid being promoted back to errors under TreatWarningsAsErrors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants