Fix high-priority Pipeline review findings (immutability, async contract, docs)#137
Merged
Chris-Wolfgang merged 1 commit intoApr 25, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on top of #134. Addresses the high-priority findings from the code review on the Pipeline API.
Fixes
WithProgresssilently allowed double-binding + stage instances were stateful/aliasableExtractStageWithProgress/TransformStageWithProgressare now fully immutable (no_progressfield, noSourceAsync).WithProgressreturns a fresh downstream stage with the sink captured.PipelineWithLoadProgress.WithProgressnow throwsInvalidOperationExceptionon a second call (it can't be made immutable cleanly because it ownsName/one-shot state).PipelineImpl.RunAsynclet sync throws escape synchronously; one-shot flag set before_runinvocationRunAsyncnow wraps body intry/catchand returnsTask.FromExceptionfor any failure (including the one-shotInvalidOperationException). Every exit now goes through the Task, as the docs promise.Pipeline.Extract/.Transform/.Load— a full-capability instance passed via a bare static type silently drops cancellation/progress<remarks>onPipelineclass docs warning about static-type overload resolution.NoProgressPathTestsasserted negative (!ProgressOverloadWasCalled) without a positive counterpart; no test forWithProgressdouble-callParameterlessOverloadWasCalledflags onProgressOnlyExtractor/Transformer/Loader; updated existing tests to assert positives; addedWithProgressSemanticsTestscovering builder immutability (Extract + Transform), pipeline one-shotWithProgress, and the async-contract normalization.Stats
Not included
Low-priority review findings (#6
Volatile.Read, #7 sentinel exception, #11 pre-cancelAssert.Empty) will land in a separate PR to keep this one focused.🤖 Generated with Claude Code