Move analyzer PackageReferences to individual csproj files#128
Merged
Conversation
Each project now owns its analyzer references directly, eliminating the need to disable branch ruleset protection when updating versions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the six analyzer PackageReferences (Roslynator, AsyncFixer, VS Threading Analyzers, BannedApiAnalyzers, Meziantou, SonarAnalyzer) from centralized configuration into individual project files so each project owns its analyzer dependencies.
Changes:
- Added the 6 analyzer
PackageReferences (withPrivateAssets=all/IncludeAssets=...) to each touched.csproj. - Applied the same analyzer versions consistently across library, tests, and example projects.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Wolfgang.Etl.Abstractions.Tests.Unit/Wolfgang.Etl.Abstractions.Tests.Unit.csproj | Adds analyzer PackageReferences to the unit test project. |
| src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj | Adds analyzer PackageReferences to the core abstractions library. |
| examples/Net8.0/Example1-BasicETL/Example1-BasicETL.csproj | Adds analyzer PackageReferences to net8.0 example. |
| examples/Net8.0/Example2-WithCancellationToken/Example2-WithCancellationToken.csproj | Adds analyzer PackageReferences to net8.0 example. |
| examples/Net8.0/Example3-WithGracefulCancellation/Example3-WithGracefulCancellation.csproj | Adds analyzer PackageReferences to net8.0 example. |
| examples/Net8.0/Example4a-WithExtractorProgress/Example4a-WithExtractorProgress.csproj | Adds analyzer PackageReferences to net8.0 example. |
| examples/Net8.0/Example4b-WithTransformerProgress/Example4b-WithTransformerProgress.csproj | Adds analyzer PackageReferences to net8.0 example. |
| examples/Net8.0/Example4c-WithLoaderProgress/Example4c-WithLoaderProgress.csproj | Adds analyzer PackageReferences to net8.0 example. |
| examples/Net8.0/Example5a-ExtractorWithProgressAndCancellation/Example5a-ExtractorWithProgressAndCancellation.csproj | Adds analyzer PackageReferences to net8.0 example. |
| examples/Net8.0/Example6-ReducingDuplicateCode/Example6-ReducingDuplicateCode.csproj | Adds analyzer PackageReferences to net8.0 example. |
| examples/Net4.8/Example1-BasicETL/Example1-BasicETL.csproj | Adds analyzer PackageReferences to net48 example. |
| examples/Net4.8/Example2-WithCancellationToken/Example2-WithCancellationToken.csproj | Adds analyzer PackageReferences to net48 example. |
| examples/Net4.8/Example3-WithGracefulCancellation/Example3-WithGracefulCancellation.csproj | Adds analyzer PackageReferences to net48 example. |
| examples/Net4.8/Example4a-WithExtractorProgress/Example4a-WithExtractorProgress.csproj | Adds analyzer PackageReferences to net48 example. |
| examples/Net4.8/Example4b-WithTransformerProgress/Example4b-WithTransformerProgress.csproj | Adds analyzer PackageReferences to net48 example. |
| examples/Net4.8/Example4c-WithLoaderProgress/Example4c-WithLoaderProgress.csproj | Adds analyzer PackageReferences to net48 example. |
| examples/Net4.8/Example5a-ExtractorWithProgressAndCancellation/Example5a-ExtractorWithProgressAndCancellation.csproj | Adds analyzer PackageReferences to net48 example. |
| examples/Net4.8/Example6-ReducingDuplicateCode/Example6-ReducingDuplicateCode.csproj | Adds analyzer PackageReferences to net48 example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prerequisites
Test plan
Directory.Build.propsis NOT modified in this PR🤖 Generated with Claude Code