Skip to content

Move analyzer PackageReferences to individual csproj files#128

Merged
Chris-Wolfgang merged 2 commits into
mainfrom
refactor/move-analyzers-to-csproj
Apr 8, 2026
Merged

Move analyzer PackageReferences to individual csproj files#128
Chris-Wolfgang merged 2 commits into
mainfrom
refactor/move-analyzers-to-csproj

Conversation

@Chris-Wolfgang
Copy link
Copy Markdown
Owner

Summary

  • Adds the 6 analyzer PackageReferences (Roslynator, AsyncFixer, Threading.Analyzers, BannedApiAnalyzers, Meziantou, SonarAnalyzer) directly to all 18 csproj files
  • Each project now owns its analyzer references, eliminating the need to disable branch ruleset protection when updating versions

Prerequisites

Test plan

  • Verify all 18 csproj files contain the 6 analyzer PackageReferences with correct versions
  • Verify Directory.Build.props is NOT modified in this PR
  • Build succeeds after both PRs are merged

🤖 Generated with Claude Code

Each project now owns its analyzer references directly, eliminating the need to disable branch ruleset protection when updating versions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 8, 2026 01:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the six analyzer PackageReferences (Roslynator, AsyncFixer, VS Threading Analyzers, BannedApiAnalyzers, Meziantou, SonarAnalyzer) from centralized configuration into individual project files so each project owns its analyzer dependencies.

Changes:

  • Added the 6 analyzer PackageReferences (with PrivateAssets=all / IncludeAssets=...) to each touched .csproj.
  • Applied the same analyzer versions consistently across library, tests, and example projects.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Wolfgang.Etl.Abstractions.Tests.Unit/Wolfgang.Etl.Abstractions.Tests.Unit.csproj Adds analyzer PackageReferences to the unit test project.
src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj Adds analyzer PackageReferences to the core abstractions library.
examples/Net8.0/Example1-BasicETL/Example1-BasicETL.csproj Adds analyzer PackageReferences to net8.0 example.
examples/Net8.0/Example2-WithCancellationToken/Example2-WithCancellationToken.csproj Adds analyzer PackageReferences to net8.0 example.
examples/Net8.0/Example3-WithGracefulCancellation/Example3-WithGracefulCancellation.csproj Adds analyzer PackageReferences to net8.0 example.
examples/Net8.0/Example4a-WithExtractorProgress/Example4a-WithExtractorProgress.csproj Adds analyzer PackageReferences to net8.0 example.
examples/Net8.0/Example4b-WithTransformerProgress/Example4b-WithTransformerProgress.csproj Adds analyzer PackageReferences to net8.0 example.
examples/Net8.0/Example4c-WithLoaderProgress/Example4c-WithLoaderProgress.csproj Adds analyzer PackageReferences to net8.0 example.
examples/Net8.0/Example5a-ExtractorWithProgressAndCancellation/Example5a-ExtractorWithProgressAndCancellation.csproj Adds analyzer PackageReferences to net8.0 example.
examples/Net8.0/Example6-ReducingDuplicateCode/Example6-ReducingDuplicateCode.csproj Adds analyzer PackageReferences to net8.0 example.
examples/Net4.8/Example1-BasicETL/Example1-BasicETL.csproj Adds analyzer PackageReferences to net48 example.
examples/Net4.8/Example2-WithCancellationToken/Example2-WithCancellationToken.csproj Adds analyzer PackageReferences to net48 example.
examples/Net4.8/Example3-WithGracefulCancellation/Example3-WithGracefulCancellation.csproj Adds analyzer PackageReferences to net48 example.
examples/Net4.8/Example4a-WithExtractorProgress/Example4a-WithExtractorProgress.csproj Adds analyzer PackageReferences to net48 example.
examples/Net4.8/Example4b-WithTransformerProgress/Example4b-WithTransformerProgress.csproj Adds analyzer PackageReferences to net48 example.
examples/Net4.8/Example4c-WithLoaderProgress/Example4c-WithLoaderProgress.csproj Adds analyzer PackageReferences to net48 example.
examples/Net4.8/Example5a-ExtractorWithProgressAndCancellation/Example5a-ExtractorWithProgressAndCancellation.csproj Adds analyzer PackageReferences to net48 example.
examples/Net4.8/Example6-ReducingDuplicateCode/Example6-ReducingDuplicateCode.csproj Adds analyzer PackageReferences to net48 example.

Comment thread src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj
@Chris-Wolfgang Chris-Wolfgang merged commit 417c521 into main Apr 8, 2026
9 checks passed
@Chris-Wolfgang Chris-Wolfgang deleted the refactor/move-analyzers-to-csproj branch April 8, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants