Skip to content

Remove netcoreapp3.1 from source TargetFrameworks #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris-Wolfgang merged 1 commit into from
Mar 28, 2026
Merged

Remove netcoreapp3.1 from source TargetFrameworks #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ jobs:
--configuration Release \
--framework "$fw" \
--collect:"XPlat Code Coverage" \
--settings coverlet.runsettings \
--results-directory "./TestResults" \
--logger "console;verbosity=minimal" || exit 1
else
Expand Down Expand Up @@ -518,7 +517,6 @@ jobs:
--configuration Release `
--framework $fw `
--collect:"XPlat Code Coverage" `
--settings coverlet.runsettings `
--results-directory "./TestResults" `
--logger "console;verbosity=normal"
} else {
Expand Down Expand Up @@ -824,7 +822,6 @@ jobs:
--configuration Release \
--framework "$fw" \
--collect:"XPlat Code Coverage" \
--settings coverlet.runsettings \
--results-directory "./TestResults" \
--logger "console;verbosity=normal" || exit 1
done <<< "$frameworks"
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ jobs:
--no-build `
--no-restore `
--collect:"XPlat Code Coverage" `
--settings coverlet.runsettings `
--results-directory "./TestResults" `
--logger "console;verbosity=minimal"

Expand All @@ -183,7 +182,6 @@ jobs:
--no-build `
--no-restore `
--collect:"XPlat Code Coverage" `
--settings coverlet.runsettings `
--results-directory "./TestResults" `
--logger "console;verbosity=minimal"
} else {
Expand Down
25 changes: 0 additions & 25 deletions coverlet.runsettings
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,6 @@
</None>
</ItemGroup>

<!-- No test project targets netstandard TFMs; exclude them from coverage so they don't
drag the aggregate below the gate. ExcludeFromCodeCoverage is the MSBuild property
read by dotCover (JetBrains), and the coverlet.runsettings ExcludeByFile handles CI. -->
<PropertyGroup Condition="$(TargetFramework.StartsWith('netstandard'))">
<ExcludeFromCodeCoverage>true</ExcludeFromCodeCoverage>
</PropertyGroup>

<!--
Microsoft.Bcl.AsyncInterfaces: the runtime assembly is built into net8+, so pre-net8 TFMs
Expand Down
Loading