Repository navigation
test: exclude the TableWithDefaults POCO from coverage; Effort.EF6 licence mapping - #406
Merged
Merged
Conversation
…Effort.EF6 licence URL The coverage gate now instruments test assemblies (template coverlet.runsettings). Models/TableWithDefaults.cs is linked into eight test projects and most only set Id, so the POCO scores 0-33% there; it has no logic to cover. The template's license-audit.yaml reads url-license-mappings.json, which lacked Effort.EF6 (URL licence, MIT text) - same mapping as repo-template#576. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a non-blocking documentation nit remains.
Pull request overview
This PR unblocks coverage and license-audit checks after the template upgrade.
Changes:
- Excludes the test-only
TableWithDefaultsPOCO from coverage. - Maps
Effort.EF6’s license URL to MIT.
File summaries
| File | Summary |
|---|---|
tests/Wolfgang.DbContextBuilder-Core.Tests.Unit/Models/TableWithDefaults.cs |
Adds coverage exclusion metadata and rationale; one minor wording correction remains. |
.github/license-audit/url-license-mappings.json |
Adds the Effort.EF6 MIT license mapping. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…cies; repo-template#576) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Licence audit was still red on two more URL-licence packages behind Effort.EF6 — |
…nk it) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfails two checks since the template upgrade (#404) — first seen on the docs-only #405.coverlet.runsettingsnow instruments test assemblies.Models/TableWithDefaults.csis a linked file compiled into eight test projects (AutoFixture, Bogus, EF6–EF10 variants); only the Core project's tests setModifiedDate/Rowguid, so the POCO scores 0%/33% in the others. It has no logic —[ExcludeFromCodeCoverage](test POCO), with the reason in the file.license-audit.yamlreads.github/license-audit/url-license-mappings.json, which lackedEffort.EF6(licence URL, not SPDX; the repo LICENSE is the MIT text). Same mapping as ci: actionlint v1.7.12 (knows windows-11-arm); Effort.EF6 licence URL → MIT repo-template#576.Release build of the solution clean. Test-only + config; no
src/change. Unblocks #405.🤖 Generated with Claude Code