build: silence scaffold/EOL warning noise (CS8669 folder-scoped, NETSDK1138)#339
Merged
Merged
Conversation
…DK1138) Two non-shipping warning sources dominated the build log (~2,142 lines): - CS8669 (nullable annotation outside a #nullable context) from the AdventureWorks-EF6/EF7 generated models. Scoped a .editorconfig to each AdventureWorks-EF*/Models/Generated folder setting CS8669 severity = none, so only generated scaffold code is affected (re-scaffolds keep the suppression). - NETSDK1138 (net7.0 out of support) from the five net7.0-targeting projects. Added <CheckEolTargetFramework>false</CheckEolTargetFramework> to each; EF Core 7 is intentionally still supported (maintenance tier). Shipping src/ code keeps TreatWarningsAsErrors and stays at 0 warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts ~2,142 lines of non-shipping warning noise from the build log. Shipping
src/code is unaffected and stays at 0 warnings under TreatWarningsAsErrors.CS8669 (nullable annotation outside a
#nullablecontext) — from the AdventureWorks-EF6/EF7 generated models. Added a folder-scoped.editorconfigto eachAdventureWorks-EF*/Models/Generated/settingdotnet_diagnostic.CS8669.severity = none, so only generated scaffold code is suppressed (survives re-scaffold; doesn't touch hand-written code).NETSDK1138 (net7.0 EOL) — added
<CheckEolTargetFramework>false</CheckEolTargetFramework>to the five net7.0-targeting projects. EF Core 7 is intentionally still supported (maintenance tier — same rationale as the existing NU1901/NU1902 suppression).Verified locally: AdventureWorks-EF7 build → 0 CS8669; Core-EF7 build → 0 NETSDK1138.
Neither warning is promoted to an error — they're non-shipping noise;
src/keeps the strict bar.