chore: sync *.ps1 EOL fix from canonical#196
Merged
Merged
Conversation
Removes the CRLF + UTF-8-BOM overrides for *.ps1 files in .gitattributes and .editorconfig. Required for the '#!/usr/bin/env pwsh' shebang at the top of every script in scripts/ to work as an executable on Linux/macOS. No file content rewrites — index has been LF the whole time. Only attr declarations align with reality now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the repo’s PowerShell script handling with the canonical template by switching *.ps1 files to LF in the Git attributes and removing CRLF/BOM overrides from .editorconfig, to keep #!/usr/bin/env pwsh-style execution working on Linux/macOS.
Changes:
- Update
.gitattributesto set*.ps1toeol=lfand revise the rationale comments. - Remove
end_of_line = crlfandcharset = utf-8-bomfrom the[*.ps1]section in.editorconfig, relying on the global defaults.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.gitattributes |
Changes *.ps1 EOL policy to LF and updates explanatory comments. |
.editorconfig |
Removes PowerShell-specific CRLF/BOM overrides and updates rationale comments. |
Chris-Wolfgang
added a commit
that referenced
this pull request
May 12, 2026
PR #196 shipped the LF-EOL switch but its .gitattributes / .editorconfig wording predated repo-template clarifications, and Copilot flagged four things that the current canonical now addresses cleanly. This catches the repo up. - .gitattributes: canonical clarifies that BOM enforcement is via .editorconfig's `charset = utf-8` (not .gitattributes), and that `eol=lf` overrides `core.autocrlf` (the previous wording implied the reverse). Resolves Copilot threads on .gitattributes:18. - .editorconfig: canonical drops the redundant `[*.ps1] indent_size = 4` block — the global `[*]` already sets `indent_size = 4`. Resolves the "indent override is redundant" thread on .editorconfig:35. - scripts/Setup-Labels.ps1: add the missing `#!/usr/bin/env pwsh` shebang. The .editorconfig comment claims a shebang exists at the top of every script in scripts/; this script was the only one missing it. Resolves the .editorconfig:33 thread. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the canonical
*.ps1EOL fix from repo-template#347 + #348. Removes the CRLF + UTF-8-BOM overrides for*.ps1files in.gitattributesand.editorconfig.Why
The
#!/usr/bin/env pwshshebang at the top of every script inscripts/doesn't work as an executable on Linux/macOS when files are stored with CRLF + BOM:#!/usr/bin/env pwsh\rand tries to find an interpreter namedpwsh\r— fails.EF BB BFappear before#!, so the kernel doesn't recognize the file as a shebang script at all.The original "PowerShell uses CRLF for Windows compatibility" rationale predates PowerShell 7+ (cross-platform). The PowerShell team's own canonical repos (
PowerShell/PowerShell,PSScriptAnalyzer) all use LF + no BOM.Changes
.gitattributes*.ps1 text eol=crlf*.ps1 text eol=lf.editorconfig [*.ps1]end_of_line = crlf,charset = utf-8-bom[*]defaults)Comments rewritten to explain the shebang rationale.
What does NOT change
core.autocrlf=true(Git for Windows default) still gives CRLF in working tree on checkout. Only the index/wire format is LF.*.ps1.Note about the protected-files guard
This PR touches
.gitattributes(in canonical the rule is in.editorconfig's domain too) and.editorconfig(protected). TheDetect .NET Projectsguard will fail it. Maintainer override required — same path as the canonical PRs.Test plan
git ls-files --eol scripts/*.ps1showsi/lf w/* attr/text eol=lfeverywhere