fix(docs): version-picker shows selected option on /versions/latest/ - #224
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DocFX site version-picker.js to correctly show a selected option when browsing documentation via the /versions/latest/ alias, by removing dead URL-resolution logic and conditionally including the latest entry only when appropriate.
Changes:
- Removes an unreachable “resolve latest to a concrete version” URL-matching block that could never succeed.
- Updates picker rendering to include the
latestoption only when the current page is/versions/latest/, so the dropdown has an explicitly selected option there.
Default currentVersion to null instead of 'latest'. Previously, any page not under /versions/<v>/ (the site root, a normal docs page) kept currentVersion = 'latest', which both included and selected the 'latest' alias in the picker. With null, those pages skip the alias and the browser selects the first concrete version (the newest release); /versions/latest/ still surfaces and selects 'latest' via the regex match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fan-out of Try-Pattern PR #247. The version-picker JS had a dead URL-match resolution block that tried to match the
latestalias URL (/<repo>/versions/latest/) against concrete version URLs (/<repo>/versions/vX.Y.Z/) — structurally different by construction, so the match NEVER succeeded. The render loop then unconditionally skipped thelatestentry, leaving no option selected on/versions/latest/.Fix: delete the dead resolution block; keep
latestas a first-class option ONLY when the reader is on/versions/latest/. On concrete-version pages the skip still applies — no redundantlatest + vX.Y.Zpair.Same patch, same file. Direct fan-out of Try-Pattern's canonical.
Verification
Try-Pattern PR verified via HTML harness across 4 URL cases; change event fires and navigates correctly. See Try-Pattern #247 for details.
🤖 Generated with Claude Code